From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH] init-xenstore-domain: cleanup all resources on a single exit path Date: Thu, 11 Feb 2016 15:38:32 +0000 Message-ID: <1455205112.814.70.camel@citrix.com> References: <1455123382-25942-1-git-send-email-ian.campbell@citrix.com> <20160211112737.GG17384@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160211112737.GG17384@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: Daniel De Graaf , ian.jackson@eu.citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Thu, 2016-02-11 at 11:27 +0000, Wei Liu wrote: > On Wed, Feb 10, 2016 at 04:56:22PM +0000, Ian Campbell wrote: > > Previously xs_fd would be left open, which is CID 1055993 (previously > > partially fixed by 3bca826aae5eb). > > > > Instead arrange for both success and error cases to cleanup everything > > on a single exit path instead of doing partial cleanup on the success > > path a few operations higher up. > > > > Signed-off-by: Ian Campbell > > Acked-by: Wei Liu Thanks, applied.