Re: [PATCH 2/3] xen: sched: add wakeup flags to the scheduler interface

[Dario Faggioli <dario.faggioli@citrix.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1377 bytes --]

On Thu, 2016-02-11 at 06:24 -0700, Jan Beulich wrote:
> > > > On 11.02.16 at 12:38, <dario.faggioli@citrix.com> wrote:
> > --- a/xen/include/xen/sched-if.h
> > +++ b/xen/include/xen/sched-if.h
> > @@ -144,7 +144,8 @@ struct scheduler {
> >      void         (*remove_vcpu)    (const struct scheduler *,
> > struct vcpu *);
> >  
> >      void         (*sleep)          (const struct scheduler *,
> > struct vcpu *);
> > -    void         (*wake)           (const struct scheduler *,
> > struct vcpu *);
> > +    void         (*wake)           (const struct scheduler *,
> > struct vcpu *,
> > +                                    unsigned int);
> 
> Just one cosmetic comment: You properly use "unsigned int" here,
> but just "unsigned" everywhere else in this patch. May I ask that
> you use the canonical full form everywhere?
> 
Of course you can :-), and I was already down to change this... But, as
a matter of fact, this patch is not going to be present in v2.

Thanks and Regards,
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel