xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Tommi Airikka <tommi@airikka.net>,
	linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org,
	david.vrabel@citrix.com, boris.ostrovsky@oracle.com
Subject: [PATCH] Fixes to Xen pcifront and pciback (v1)
Date: Thu, 11 Feb 2016 16:10:22 -0500	[thread overview]
Message-ID: <1455225026-25792-1-git-send-email-konrad.wilk@oracle.com> (raw)

Hey,

These are patches that were developed for the Debian bug
810379 which san Tommi had openned.

The issue around from the two XSA fixes - which introduced
this regression.

I am the person who developed them and my explanation for this
regression oversight is that I tested for the 'exploit use-case'
and also did not have the VF automatic testing for PV guests
working at that point (only for HVM guests). When testing it
with with an PF in PV mode it worked - as the device would
fallback to legacy interrupts so things looked fine (argh)
from the outside (could ping it).

Either way it is embarrassing and I am sorry for the trouble
this caused.

Now the patches:
 [PATCH 1/4] xen/pciback: Check PF instead of VF for

Fixes regression introduced by XSA-157 for VF guests that
use MSI-X.

 [PATCH 2/4] xen/pciback: Save the number of MSI-X entries to be

Fixes regression introduced by XSA-155 - where MSI-X vectors
would not be copied back to the guest.

 [PATCH 3/4] xen/pcifront: Report the errors better.

Makes it easier to troubleshoot in the future.
 [PATCH 4/4] xen/pcifront: Fix mysterious crashes when NUMA locality

This one I think has been in the driver since the first time
the PV driver was introduced.

 arch/x86/include/asm/xen/pci.h        |  4 ++--
 arch/x86/pci/xen.c                    |  5 ++++-
 drivers/pci/xen-pcifront.c            | 11 +++++++----
 drivers/xen/xen-pciback/pciback_ops.c | 12 +++++++++---
 4 files changed, 22 insertions(+), 10 deletions(-)

Konrad Rzeszutek Wilk (4):
      xen/pciback: Check PF instead of VF for PCI_COMMAND_MEMORY
      xen/pciback: Save the number of MSI-X entries to be copied later.
      xen/pcifront: Report the errors better.
      xen/pcifront: Fix mysterious crashes when NUMA locality information was extracted.

             reply	other threads:[~2016-02-11 21:10 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-11 21:10 Konrad Rzeszutek Wilk [this message]
2016-02-11 21:10 ` [PATCH 1/4] xen/pciback: Check PF instead of VF for PCI_COMMAND_MEMORY Konrad Rzeszutek Wilk
2016-02-12  9:19   ` Jan Beulich
2016-02-11 21:10 ` [PATCH 2/4] xen/pciback: Save the number of MSI-X entries to be copied later Konrad Rzeszutek Wilk
2016-02-12  9:25   ` Jan Beulich
2016-02-11 21:10 ` [PATCH 3/4] xen/pcifront: Report the errors better Konrad Rzeszutek Wilk
2016-02-11 21:10 ` [PATCH 4/4] xen/pcifront: Fix mysterious crashes when NUMA locality information was extracted Konrad Rzeszutek Wilk
2016-02-14  1:23   ` Boris Ostrovsky
     [not found]   ` <56BFD702.9010708@oracle.com>
2016-02-15 14:05     ` Konrad Rzeszutek Wilk
2016-02-15 14:37       ` Boris Ostrovsky
2016-02-15 14:27   ` David Vrabel
2016-02-15 14:35 ` [PATCH] Fixes to Xen pcifront and pciback (v1) David Vrabel
     [not found] ` <56C1E24C.5040704@citrix.com>
2016-02-15 14:38   ` David Vrabel
     [not found]   ` <56C1E2DE.7030507@citrix.com>
2016-02-15 15:35     ` Konrad Rzeszutek Wilk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1455225026-25792-1-git-send-email-konrad.wilk@oracle.com \
    --to=konrad.wilk@oracle.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=david.vrabel@citrix.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tommi@airikka.net \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).