From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH] libxl: fix handling returns in
	libxl_get_version_info()
Date: Fri, 12 Feb 2016 12:12:45 +0100
Message-ID: <1455275565.3148.349.camel@citrix.com>
References: <1455179459-3392-1-git-send-email-write.harmandeep@gmail.com>
	<1455184090.3148.275.camel@citrix.com>
	<CAPtdW16S45rgw8rFR9tevaSTM5W4sB09epWYnTU1-gNGVOa6rA@mail.gmail.com>
	<1455274806.3148.347.camel@citrix.com>
	<CAPtdW14We1exZ8Lp=d5c2VH9SH7apUeSQoPXH1Fyf2MNZwRn+Q@mail.gmail.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1055722187320332213=="
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=84325ddab=dario.faggioli@citrix.com>)
	id 1aUBee-0001Ef-GX
	for xen-devel@lists.xenproject.org; Fri, 12 Feb 2016 11:12:52 +0000
In-Reply-To: <CAPtdW14We1exZ8Lp=d5c2VH9SH7apUeSQoPXH1Fyf2MNZwRn+Q@mail.gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Harmandeep Kaur <write.harmandeep@gmail.com>
Cc: xen-devel@lists.xenproject.org, wei.liu2@citrix.com, ian.jackson@eu.citrix.com, Ian Campbell <ian.campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

--===============1055722187320332213==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-vVk2KYbRwDADpoY5UvWA"

--=-vVk2KYbRwDADpoY5UvWA
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, 2016-02-12 at 16:34 +0530, Harmandeep Kaur wrote:
> On Fri, Feb 12, 2016 at 4:30 PM, Dario Faggioli
> <dario.faggioli@citrix.com> wrote:
> >=C2=A0
> Sorry I actually meant,
> tools/libxl/xl_cmdimpl.c:=C2=A0=C2=A0=C2=A0=C2=A0vinfo =3D libxl_get_vers=
ion_info(ctx);
>=20
> vinfo =3D libxl_get_version_info(ctx);
> =C2=A0=C2=A0=C2=A0=C2=A0if (vinfo) {
>
Which again checks for vinfo to not be NULL before using it, so this
also seems ok to me.

> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0i =3D (1 << 20) / vinfo->=
pagesize;
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0printf("total_memory=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0: %"PRIu64"\=
n",
> info.total_pages / i);
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0printf("free_memory=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0: %"PRIu6=
4"\n",
> (info.free_pages - info.outstanding_pages) / i);
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0printf("sharing_freed_mem=
ory=C2=A0=C2=A0=C2=A0: %"PRIu64"\n",
> info.sharing_freed_pages / i);
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0printf("sharing_used_memo=
ry=C2=A0=C2=A0=C2=A0=C2=A0: %"PRIu64"\n",
> info.sharing_used_frames / i);
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0printf("outstanding_claim=
s=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0: %"PRIu64"\n",
> info.outstanding_pages / i);
> =C2=A0=C2=A0=C2=A0=C2=A0}
>=20
Dario
--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


--=-vVk2KYbRwDADpoY5UvWA
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEABECAAYFAla9vi0ACgkQk4XaBE3IOsTdbQCfV3f7B2s+QcklzTc2gTielO5T
Hn0An3NaaYlJs+dZGVnKA+Mf26QfJr1C
=2jgt
-----END PGP SIGNATURE-----

--=-vVk2KYbRwDADpoY5UvWA--


--===============1055722187320332213==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============1055722187320332213==--