From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH 11/14] xenalyze: handle scheduling events Date: Mon, 15 Feb 2016 18:03:28 +0100 Message-ID: <1455555808.14334.76.camel@citrix.com> References: <20160205183137.4543.56523.stgit@Solace.station> <20160205183522.4543.48578.stgit@Solace.station> <20160215165141.GK4697@char.us.oracle.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2994364363393293120==" Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aVMYh-0007rD-Cg for xen-devel@lists.xenproject.org; Mon, 15 Feb 2016 17:03:35 +0000 In-Reply-To: <20160215165141.GK4697@char.us.oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Konrad Rzeszutek Wilk Cc: Olaf Hering , Wei Liu , Ian Campbell , George Dunlap , Ian Jackson , xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org --===============2994364363393293120== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-L5hq9PF6SFIfboNl6PLO" --=-L5hq9PF6SFIfboNl6PLO Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2016-02-15 at 11:51 -0500, Konrad Rzeszutek Wilk wrote: > On Fri, Feb 05, 2016 at 07:35:22PM +0100, Dario Faggioli wrote: > >=C2=A0 > > @@ -7559,6 +7546,14 @@ void sched_summary_domain(struct domain_data > > *d) > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0} > > =C2=A0} > > =C2=A0 > > +void dump_sched_vcpu_action(struct record_info *ri, const char > > *action) > > +{ > > +=C2=A0=C2=A0=C2=A0=C2=A0struct { > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0unsigned int domid, vc= puid; > > +=C2=A0=C2=A0=C2=A0=C2=A0} * r =3D (typeof(r))ri->d; > > + > > +=C2=A0=C2=A0=C2=A0=C2=A0printf(" %s %s d%uv%u\n", ri->dump_header, act= ion, r->domid, > > r->vcpuid); > > +} >=20 > I know that 'sched_switch_process' used to have '} * r =3D' type but > there > are different pieces of code that do: "} *r =3D" > (mem_pod_zero_reclaim_process) >=20 Ah, good point. I did not notice that, as, as you say, I just moved/replicated what I found in sched_switch_process. > Could all of the patches use the '*r =3D ' style? There are more of > them: >=20 > [konrad@x230 xentrace]$ cat xenalyze.c | grep "} \*r =3D"=C2=A0=C2=A0=C2= =A0| wc > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A032=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0128=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0942 > [konrad@x230 xentrace]$ cat xenalyze.c | grep "} \* r =3D" | wc > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A03=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= 17=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A092 >=20 Yep, I'll do this. > Besides that: >=20 > Reviewed-by: Konrad Rzeszutek Wilk >=20 Thanks. > on this and the other patches that touch xenalyze.c (that is with the > modification to * r =3D .. >=20 Sure! Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-L5hq9PF6SFIfboNl6PLO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEABECAAYFAlbCBOAACgkQk4XaBE3IOsS+QQCgn/dD+7FGynUlURBKh1F0NwW3 o2MAoJ8XuHFtHoHcpLrBZ8w1rd23SUAM =hh6Q -----END PGP SIGNATURE----- --=-L5hq9PF6SFIfboNl6PLO-- --===============2994364363393293120== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============2994364363393293120==--