From: Ian Campbell <ian.campbell@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
Ian Jackson <ian.jackson@eu.citrix.com>,
Samuel Thibault <samuel.thibault@ens-lyon.org>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCH] stubdom: fix link farm runes
Date: Tue, 16 Feb 2016 12:14:33 +0000 [thread overview]
Message-ID: <1455624873.15441.58.camel@citrix.com> (raw)
In-Reply-To: <20160216102935.GG10489@citrix.com>
On Tue, 2016-02-16 at 10:29 +0000, Wei Liu wrote:
> On Tue, Feb 16, 2016 at 09:10:20AM +0000, Ian Campbell wrote:
> > On Mon, 2016-02-15 at 19:40 +0000, Wei Liu wrote:
> > > Previously in the three problematic libraries all public headers
> were
> > > linked to source code directory. We should have created a include
> > > directory and link headers there.
> >
> > What breakage arose from not having done so?
> >
>
> No visible breakage for these three packages. I noticed this deviation
> when working on devicemodel library and thought they should follow the
> same pattern as other libraries.
Thanks. This sort of thing is worth noting in the commit log.
Ian.
next prev parent reply other threads:[~2016-02-16 12:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-15 19:40 [PATCH] stubdom: fix link farm runes Wei Liu
2016-02-15 19:49 ` Wei Liu
2016-02-15 19:56 ` Samuel Thibault
2016-02-16 9:10 ` Ian Campbell
2016-02-16 10:29 ` Wei Liu
2016-02-16 12:14 ` Ian Campbell [this message]
2016-02-16 12:15 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1455624873.15441.58.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=samuel.thibault@ens-lyon.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).