From: Ian Campbell <ian.campbell@citrix.com>
To: Jim Fehlig <jfehlig@suse.com>, xen-devel@lists.xen.org
Cc: wei.liu2@citrix.com, ian.jackson@eu.citrix.com
Subject: Re: [PATCH 1/3] libxlu_cfg: reject unknown characters following '\'
Date: Wed, 17 Feb 2016 10:11:36 +0000 [thread overview]
Message-ID: <1455703896.814.149.camel@citrix.com> (raw)
In-Reply-To: <1455703535.814.142.camel@citrix.com>
On Wed, 2016-02-17 at 10:05 +0000, Ian Campbell wrote:
> On Tue, 2016-02-16 at 20:54 -0700, Jim Fehlig wrote:
> > When dequoting config strings in xlu__cfgl_dequote(), unknown
> > characters following a '\', and the '\' itself, are discarded.
> > E.g. a disk configuration string containing
> >
> > rbd:pool/image:mon_host=192.168.0.100\:6789
> >
> > would be dequoted as
> >
> > rbd:pool/image:mon_host=192.168.0.1006789
> >
> > Instead of discarding the '\' and unknown character, reject the
> > string and set error to EINVAL.
>
> Missing your S-o-b.
>
> Other than that:
>
> > + xlu__cfgl_lexicalerror(ctx, "invalid character after
> > backlash "
> > + "in quoted string");
>
> Please try where possible not to split string constants (so log messages
> can more easily be grepped for).
I see now that this parsing code is pretty liberally ignoring this advice
already. So apart from the missing S-o-b this patch is
Acked-by: Ian Campbell < ian.campbell@citrix.com >
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-02-17 10:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-17 3:54 [PATCH 0/3] libxl and docs: small improvements in qdisk support Jim Fehlig
2016-02-17 3:54 ` [PATCH 1/3] libxlu_cfg: reject unknown characters following '\' Jim Fehlig
2016-02-17 10:05 ` Ian Campbell
2016-02-17 10:11 ` Ian Campbell [this message]
2016-02-17 17:26 ` Jim Fehlig
2016-02-17 3:54 ` [PATCH 2/3] docs: fix typo in xl-disk-configuration.txt Jim Fehlig
2016-02-17 10:05 ` Ian Campbell
2016-02-17 3:54 ` [PATCH 3/3] docs: add more info about target= in disk config Jim Fehlig
2016-02-17 10:10 ` Ian Campbell
2016-02-17 17:24 ` Jim Fehlig
2016-02-18 10:22 ` Ian Campbell
2016-02-19 17:23 ` Ian Jackson
2016-02-19 19:06 ` Jim Fehlig
2016-02-23 9:52 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1455703896.814.149.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jfehlig@suse.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).