From: Ian Campbell <ian.campbell@citrix.com>
To: ian.jackson@eu.citrix.com, xen-devel@lists.xen.org
Cc: Ian Campbell <ian.campbell@citrix.com>
Subject: [PATCH OSSTEST] mg-show-flight-runvars: avoid "SELECT .. AND TRUE" for sqlite
Date: Wed, 17 Feb 2016 10:51:59 +0000 [thread overview]
Message-ID: <1455706319-24690-1-git-send-email-ian.campbell@citrix.com> (raw)
c5e29f93fb6e "mg-show-flight-runvars: recurse on buildjobs upon
request" broke standalone mode with:
Error: no such column: TRUE
from sqlite. Do as is done for $syntcond and use (1=1) instead.
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
mg-show-flight-runvars | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mg-show-flight-runvars b/mg-show-flight-runvars
index c847456..d708fed 100755
--- a/mg-show-flight-runvars
+++ b/mg-show-flight-runvars
@@ -53,7 +53,7 @@ our %jobs;
sub collect ($;$@) {
my ($flight,$jobcond,@jobcondparams) = @_;
- $jobcond //= "TRUE";
+ $jobcond //= "(1=1)";
$flight =~ m/^\d+/ or $flight = "'$flight'";
my $qfrom = "FROM runvars WHERE flight=$flight AND $synthcond AND $jobcond";
--
2.6.1
reply other threads:[~2016-02-17 10:51 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1455706319-24690-1-git-send-email-ian.campbell@citrix.com \
--to=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).