From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: [PATCH 1/3] xl: free config_data on error in domain_create Date: Wed, 17 Feb 2016 14:04:13 +0000 Message-ID: <1455717855-2344-1-git-send-email-ian.campbell@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: ian.jackson@eu.citrix.com, wei.liu2@citrix.com, xen-devel@lists.xen.org Cc: Ian Campbell List-Id: xen-devel@lists.xenproject.org CID: 1055898 Signed-off-by: Ian Campbell --- tools/libxl/xl_cmdimpl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c index d5a397a..e819ee6 100644 --- a/tools/libxl/xl_cmdimpl.c +++ b/tools/libxl/xl_cmdimpl.c @@ -2795,6 +2795,7 @@ static uint32_t create_domain(struct domain_create *dom_info) if (!restoring && extra_config && strlen(extra_config)) { if (config_len > INT_MAX - (strlen(extra_config) + 2 + 1)) { fprintf(stderr, "Failed to attach extra configuration\n"); + free(config_data); return ERROR_FAIL; } /* allocate space for the extra config plus two EOLs plus \0 */ @@ -6525,6 +6526,7 @@ int main_networkattach(int argc, char **argv) } xlu_cfg_destroy(config); + config = NULL; if (argc > 0) return 1; /* Parse error above */ -- 2.1.4