xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: ian.jackson@eu.citrix.com, wei.liu2@citrix.com, xen-devel@lists.xen.org
Cc: Ian Campbell <ian.campbell@citrix.com>
Subject: [PATCH] xenpaging: don't try to log via xch if xc_interface_close fails
Date: Wed, 17 Feb 2016 15:39:55 +0000	[thread overview]
Message-ID: <1455723595-30904-1-git-send-email-ian.campbell@citrix.com> (raw)

Since xch may not be valid (enough) any longer, xc_interface_close
already logs anything of any use before it tears down the integrated
logger so there is no need to log any further in the application via
that path.

CID: 1056203

Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
 tools/xenpaging/xenpaging.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/tools/xenpaging/xenpaging.c b/tools/xenpaging/xenpaging.c
index 6157d3a..d0571ca 100644
--- a/tools/xenpaging/xenpaging.c
+++ b/tools/xenpaging/xenpaging.c
@@ -550,11 +550,7 @@ static void xenpaging_teardown(struct xenpaging *paging)
     xs_close(paging->xs_handle);
 
     /* Close connection to Xen */
-    rc = xc_interface_close(xch);
-    if ( rc != 0 )
-    {
-        ERROR("Error closing connection to xen");
-    }
+    xc_interface_close(xch);
 }
 
 static void get_request(struct vm_event *vm_event, vm_event_request_t *req)
-- 
2.1.4

             reply	other threads:[~2016-02-17 15:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-17 15:39 Ian Campbell [this message]
2016-02-19 16:45 ` [PATCH] xenpaging: don't try to log via xch if xc_interface_close fails Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1455723595-30904-1-git-send-email-ian.campbell@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).