* [PATCH] xenpaging: don't try to log via xch if xc_interface_close fails
@ 2016-02-17 15:39 Ian Campbell
2016-02-19 16:45 ` Ian Jackson
0 siblings, 1 reply; 2+ messages in thread
From: Ian Campbell @ 2016-02-17 15:39 UTC (permalink / raw)
To: ian.jackson, wei.liu2, xen-devel; +Cc: Ian Campbell
Since xch may not be valid (enough) any longer, xc_interface_close
already logs anything of any use before it tears down the integrated
logger so there is no need to log any further in the application via
that path.
CID: 1056203
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
tools/xenpaging/xenpaging.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/tools/xenpaging/xenpaging.c b/tools/xenpaging/xenpaging.c
index 6157d3a..d0571ca 100644
--- a/tools/xenpaging/xenpaging.c
+++ b/tools/xenpaging/xenpaging.c
@@ -550,11 +550,7 @@ static void xenpaging_teardown(struct xenpaging *paging)
xs_close(paging->xs_handle);
/* Close connection to Xen */
- rc = xc_interface_close(xch);
- if ( rc != 0 )
- {
- ERROR("Error closing connection to xen");
- }
+ xc_interface_close(xch);
}
static void get_request(struct vm_event *vm_event, vm_event_request_t *req)
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-02-19 16:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-17 15:39 [PATCH] xenpaging: don't try to log via xch if xc_interface_close fails Ian Campbell
2016-02-19 16:45 ` Ian Jackson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).