xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: wei.liu2@citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org
Subject: Re: [PATCH] tools: remove xenpmd
Date: Thu, 18 Feb 2016 10:20:34 +0000	[thread overview]
Message-ID: <1455790834.6225.16.camel@citrix.com> (raw)
In-Reply-To: <20160217170540.GC23247@char.us.oracle.com>

On Wed, 2016-02-17 at 12:05 -0500, Konrad Rzeszutek Wilk wrote:
> On Wed, Feb 17, 2016 at 02:41:14PM +0000, Ian Campbell wrote:
> > It has four instances of the same CID 1198719 (strncpy(..., 32) into a
> > 32-byte buffer).
> > 
> > However ever since it was checked in in 2008 it has contained a
> > /tmp instead of the real ones in /proc. I therefore conclude that it
> > has not ever been used in its current form in the last 8 years and
> > might as well therefore be deleted. The code remains in the git
> > history should anyone one to reanimate it.
> > 
> > Searching online shows no references to the use of this tool.
> > 
> > Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> 
> Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> 
> .. Can I commit this in now :-)

I think formally it probably needs an Ack from Wei or Ian?

I usually give this sort of thing (removals etc) a little longer than
normal to give more of a chance for objections, although the counter to
that is that once this is committed it could just as easily be reverted the
next day as in 6 months time if someone turns up with a good reason it
shouldn't have been nuked.

Ian.

  reply	other threads:[~2016-02-18 10:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-17 14:41 [PATCH] tools: remove xenpmd Ian Campbell
2016-02-17 17:05 ` Konrad Rzeszutek Wilk
2016-02-18 10:20   ` Ian Campbell [this message]
2016-02-19 17:12     ` Ian Jackson
2016-02-22 19:51       ` Ross Philipson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1455790834.6225.16.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=konrad.wilk@oracle.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).