From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v2 04/16] xen: credit2: pack trace data better for xentrace_format Date: Thu, 18 Feb 2016 14:42:12 +0100 Message-ID: <1455802932.9726.86.camel@citrix.com> References: <20160216180550.27876.22680.stgit@Solace.station> <20160216181136.27876.29825.stgit@Solace.station> <56C5A696.1060109@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1824574321765889660==" Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aWOqZ-0003MS-QD for xen-devel@lists.xenproject.org; Thu, 18 Feb 2016 13:42:19 +0000 In-Reply-To: <56C5A696.1060109@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: George Dunlap , xen-devel@lists.xenproject.org Cc: Olaf Hering List-Id: xen-devel@lists.xenproject.org --===============1824574321765889660== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-31mi44Oskidlw2j1Wu53" --=-31mi44Oskidlw2j1Wu53 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2016-02-18 at 11:10 +0000, George Dunlap wrote: > On 16/02/16 18:11, Dario Faggioli wrote: > > when tracing runstate changes, the vcpu and domain IDs > > are encoded in the lower and higher, respectively, parts > > of a 32 bits integer. When decoding a trace with > > xentrace_format, this makes it possible to display > > such events like this: > >=20 > > CPU0=C2=A0=C2=A0833435853624 (+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0768)=C2=A0= =C2=A0running_to_runnable [ dom:vcpu =3D > > 0x7fff0000 ] > > CPU0=C2=A0=C2=A0833435854416 (+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0792)=C2=A0= =C2=A0runnable_to_running [ dom:vcpu =3D > > 0x00000007 ] > >=20 > > For consistency, we should do the same when displaying > > the events coming from the Credit2 scheduler (when using > > the same tool), and to do that, we need to invert the > > order in which the fields are being put in the trace > > struct right now. > >=20 > > Signed-off-by: Dario Faggioli > > Reviewed-by: Konrad Rzeszutek Wilk >=20 > I was going to say, "We should change xentrace_format and xenalyze in > lockstep", but it turns out that they don't support these trace > records > yet!=C2=A0=C2=A0=C2=A0I must have some patches to xenalyze in a local bra= nch > somewhere > that I never upstreamed properly. >=20 If I understand what you mean, I'm doing exactly that in the second half of this series (and per the latest email, the xentrace_format part, you've seen it already). :-) > So, all is well: >=20 > Acked-by: George Dunlap >=20 Thanks, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-31mi44Oskidlw2j1Wu53 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEABECAAYFAlbFyjQACgkQk4XaBE3IOsQytQCeOsTNmzb41x8mZoR5WchH6NBM Zo8An2PHtzqyn+xPawDlUXWywXj3x0dO =WHsd -----END PGP SIGNATURE----- --=-31mi44Oskidlw2j1Wu53-- --===============1824574321765889660== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============1824574321765889660==--