From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v2 15/16] xenalyze: handle RTDS scheduler events Date: Thu, 18 Feb 2016 18:10:00 +0100 Message-ID: <1455815400.7213.20.camel@citrix.com> References: <20160216180550.27876.22680.stgit@Solace.station> <20160216181322.27876.60708.stgit@Solace.station> <56C5E32C.5070204@citrix.com> <1455814938.7213.17.camel@citrix.com> <56C5FA26.6060801@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1268383532922661274==" Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aWS5o-00023P-TP for xen-devel@lists.xenproject.org; Thu, 18 Feb 2016 17:10:17 +0000 In-Reply-To: <56C5FA26.6060801@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: George Dunlap , xen-devel@lists.xenproject.org Cc: Olaf Hering , Wei Liu , Ian Campbell , George Dunlap , Tianyang Chen , Ian Jackson , Meng Xu List-Id: xen-devel@lists.xenproject.org --===============1268383532922661274== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-4bZe5EnY4Iz8QuR5zmNJ" --=-4bZe5EnY4Iz8QuR5zmNJ Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2016-02-18 at 17:06 +0000, George Dunlap wrote: > On 18/02/16 17:02, Dario Faggioli wrote: > > On Thu, 2016-02-18 at 15:28 +0000, George Dunlap wrote: > > >=C2=A0 > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0case TRC_SCHED_CLA= SS_EVT(RTDS, 2): /* > > > > RUNQ_PICK=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0*/ > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0if(opt.dump_all) { > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0struct { > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0unsigned int vcpuid:1= 6, domid:16; > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0unsigned int cur_dl_l= o, cur_dl_hi; > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0unsigned int cur_bg_l= o, cur_bg_hi; > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0} *r =3D (typeof(r))ri->d; > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0uint64_t dl =3D (((uint64_t)r->cur_dl_hi) << = 32) > > > > + > > > > r->cur_dl_lo; > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0uint64_t bg =3D (((uint64_t)r->cur_bg_hi) << = 32) > > > > + > > > > r->cur_bg_lo; > > >=20 > > > Why are you doing this, instead of just using uint64_t? > > >=20 > > It was to make the struct in sched_rt.c and here exactly match, for > > ease of someone reading both the pieces of code at the same time, > > to > > understand what's being printed. > >=20 > > However, yes, using uint64_t is probably equally understandable, > > and > > more readable in case one only look at this code, so I can change > > this > > (and resend). >=20 > Hrm, well perhaps having the struct match exactly is better. >=20 > I think most of these patches can be checked in now.=C2=A0=C2=A0What abou= t > checking in the other patches, then sending a follow-up series with > the > struct changed in the scheduler, and then this patch with the > resulting > changes? >=20 This would work for me. Regards, Dario --=C2=A0 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-4bZe5EnY4Iz8QuR5zmNJ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEABECAAYFAlbF+uoACgkQk4XaBE3IOsSnJgCfXC6Qlp9MnP66v+WWGGnUMQQY yUUAnj8EMPbW6ME4gBdpA/QSN6YHywQ/ =1x5E -----END PGP SIGNATURE----- --=-4bZe5EnY4Iz8QuR5zmNJ-- --===============1268383532922661274== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============1268383532922661274==--