Is there a way to get the current PV domain's UUID?

Is there a way to get the current PV domain's UUID?

[Razvan Cojocaru]

Hello,

Is there a way to get the UUID of a currently running PV domain, from
within that domain?


Thanks,
Razvan

Re: Is there a way to get the current PV domain's UUID?

[Razvan Cojocaru]

> Is there a way to get the UUID of a currently running PV domain, from
> within that domain?

Found it, in case it helps someone else:
http://old-list-archives.xenproject.org/xen-devel/2006-05/msg01127.html


Thanks,
Razvan

Re: Is there a way to get the current PV domain's UUID?

[Ian Campbell]

On Fri, 2016-02-19 at 12:10 +0200, Razvan Cojocaru wrote:
> Hello,
> 
> Is there a way to get the UUID of a currently running PV domain, from
> within that domain?

The type associated with the UUID in the xen public headers is
"xen_domain_handle_t" which is presumably why grepping didn't find it for
you.

Look for XENVER_guest_handle.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: Is there a way to get the current PV domain's UUID?

[Razvan Cojocaru]

On 02/19/2016 12:20 PM, Ian Campbell wrote:
> On Fri, 2016-02-19 at 12:10 +0200, Razvan Cojocaru wrote:
>> Hello,
>>
>> Is there a way to get the UUID of a currently running PV domain, from
>> within that domain?
> 
> The type associated with the UUID in the xen public headers is
> "xen_domain_handle_t" which is presumably why grepping didn't find it for
> you.
> 
> Look for XENVER_guest_handle.

Much appreciated, that's much better than the XenStore hack.


Thanks,
Razvan

Re: Is there a way to get the current PV domain's UUID?

[Ian Campbell]

On Fri, 2016-02-19 at 12:44 +0200, Razvan Cojocaru wrote:
> On 02/19/2016 12:20 PM, Ian Campbell wrote:
> > On Fri, 2016-02-19 at 12:10 +0200, Razvan Cojocaru wrote:
> > > Hello,
> > > 
> > > Is there a way to get the UUID of a currently running PV domain, from
> > > within that domain?
> > 
> > The type associated with the UUID in the xen public headers is
> > "xen_domain_handle_t" which is presumably why grepping didn't find it
> > for
> > you.
> > 
> > Look for XENVER_guest_handle.
> 
> Much appreciated, that's much better than the XenStore hack.

BTW, under Linux this is also exposed to userspace via /sys/hypervisor/uuid

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

[PATCH] version: Document guest_handle

[Konrad Rzeszutek Wilk]

And what it is usually used for.

Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
 xen/include/public/version.h | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/xen/include/public/version.h b/xen/include/public/version.h
index adca602..b97fc68 100644
--- a/xen/include/public/version.h
+++ b/xen/include/public/version.h
@@ -79,6 +79,10 @@ typedef struct xen_feature_info xen_feature_info_t;
 #define XENVER_pagesize 7
 
 /* arg == xen_domain_handle_t. */
+/*
+ * The toolstack fills it out for the guest consumption. Usually it is
+ * the UUID of the guest but can be anything.
+ */
 #define XENVER_guest_handle 8
 
 #define XENVER_commandline 9
-- 
2.5.0

Re: [PATCH] version: Document guest_handle

[Razvan Cojocaru]

On 02/19/2016 04:32 PM, Konrad Rzeszutek Wilk wrote:
> And what it is usually used for.
> 
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> ---
>  xen/include/public/version.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/xen/include/public/version.h b/xen/include/public/version.h
> index adca602..b97fc68 100644
> --- a/xen/include/public/version.h
> +++ b/xen/include/public/version.h
> @@ -79,6 +79,10 @@ typedef struct xen_feature_info xen_feature_info_t;
>  #define XENVER_pagesize 7
>  
>  /* arg == xen_domain_handle_t. */
> +/*
> + * The toolstack fills it out for the guest consumption. Usually it is
> + * the UUID of the guest but can be anything.
> + */
>  #define XENVER_guest_handle 8
>  
>  #define XENVER_commandline 9

I'm not a maintainer for this code, so an Ack would be meaningless, but
I just wanted to say thanks for documenting this. :)


Thanks,
Razvan

Re: [PATCH] version: Document guest_handle

[Konrad Rzeszutek Wilk]

On Fri, Feb 19, 2016 at 04:36:14PM +0200, Razvan Cojocaru wrote:
> On 02/19/2016 04:32 PM, Konrad Rzeszutek Wilk wrote:
> > And what it is usually used for.
> > 
> > Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> > ---
> >  xen/include/public/version.h | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/xen/include/public/version.h b/xen/include/public/version.h
> > index adca602..b97fc68 100644
> > --- a/xen/include/public/version.h
> > +++ b/xen/include/public/version.h
> > @@ -79,6 +79,10 @@ typedef struct xen_feature_info xen_feature_info_t;
> >  #define XENVER_pagesize 7
> >  
> >  /* arg == xen_domain_handle_t. */
> > +/*
> > + * The toolstack fills it out for the guest consumption. Usually it is
> > + * the UUID of the guest but can be anything.
> > + */
> >  #define XENVER_guest_handle 8
> >  
> >  #define XENVER_commandline 9
> 
> I'm not a maintainer for this code, so an Ack would be meaningless, but
> I just wanted to say thanks for documenting this. :)

You can always do: Reviewed-by: :-)

> 
> 
> Thanks,
> Razvan

Re: [PATCH] version: Document guest_handle

[Razvan Cojocaru]

On 02/19/2016 04:32 PM, Konrad Rzeszutek Wilk wrote:
> And what it is usually used for.
> 
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> ---
>  xen/include/public/version.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/xen/include/public/version.h b/xen/include/public/version.h
> index adca602..b97fc68 100644
> --- a/xen/include/public/version.h
> +++ b/xen/include/public/version.h
> @@ -79,6 +79,10 @@ typedef struct xen_feature_info xen_feature_info_t;
>  #define XENVER_pagesize 7
>  
>  /* arg == xen_domain_handle_t. */
> +/*
> + * The toolstack fills it out for the guest consumption. Usually it is
> + * the UUID of the guest but can be anything.
> + */
>  #define XENVER_guest_handle 8
>  
>  #define XENVER_commandline 9

Reviewed-by: Razvan Cojocaru <rcojocaru@bitdefender.com>


Thanks,
Razvan

Re: [PATCH] version: Document guest_handle

[Jan Beulich]

>>> On 19.02.16 at 15:32, <konrad@kernel.org> wrote:
> --- a/xen/include/public/version.h
> +++ b/xen/include/public/version.h
> @@ -79,6 +79,10 @@ typedef struct xen_feature_info xen_feature_info_t;
>  #define XENVER_pagesize 7
>  
>  /* arg == xen_domain_handle_t. */
> +/*
> + * The toolstack fills it out for the guest consumption. Usually it is
> + * the UUID of the guest but can be anything.
> + */
>  #define XENVER_guest_handle 8

Generally fine, but I'm not overly happy with the wording. I'd
prefer if it was made slightly less vague this is meant to be the
UUID. Maybe "The toolstack fills it out for guest consumption. It
is intended to hold the UUID of the guest"?

Jan

Re: [PATCH] version: Document guest_handle

[Konrad Rzeszutek Wilk]

[-- Attachment #1: Type: text/plain, Size: 1881 bytes --]

On Mon, Feb 22, 2016 at 05:32:53AM -0700, Jan Beulich wrote:
> >>> On 19.02.16 at 15:32, <konrad@kernel.org> wrote:
> > --- a/xen/include/public/version.h
> > +++ b/xen/include/public/version.h
> > @@ -79,6 +79,10 @@ typedef struct xen_feature_info xen_feature_info_t;
> >  #define XENVER_pagesize 7
> >  
> >  /* arg == xen_domain_handle_t. */
> > +/*
> > + * The toolstack fills it out for the guest consumption. Usually it is
> > + * the UUID of the guest but can be anything.
> > + */
> >  #define XENVER_guest_handle 8
> 
> Generally fine, but I'm not overly happy with the wording. I'd
> prefer if it was made slightly less vague this is meant to be the
> UUID. Maybe "The toolstack fills it out for guest consumption. It
> is intended to hold the UUID of the guest"?
> 
> Jan
> 

Attached as well:

>From 7da6d169835acb4aa93bfa48b1ae6b8e198f8e5f Mon Sep 17 00:00:00 2001
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Date: Fri, 19 Feb 2016 09:26:02 -0500
Subject: [PATCH] version: Document guest_handle

And what it is usually used for.

Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Reviewed-by: Razvan Cojocaru <rcojocaru@bitdefender.com>

---
v2: Reword per Jan's suggestion.
---
 xen/include/public/version.h | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/xen/include/public/version.h b/xen/include/public/version.h
index adca602..5e6a7ea 100644
--- a/xen/include/public/version.h
+++ b/xen/include/public/version.h
@@ -78,7 +78,11 @@ typedef struct xen_feature_info xen_feature_info_t;
 /* arg == NULL; returns host memory page size. */
 #define XENVER_pagesize 7
 
-/* arg == xen_domain_handle_t. */
+/* arg == xen_domain_handle_t.
+ *
+ * The toolstack fills it out for guest consumption. It is intended to hold
+ * the UUID of the guest.
+ */
 #define XENVER_guest_handle 8
 
 #define XENVER_commandline 9
-- 
2.1.0


[-- Attachment #2: 0001-version-Document-guest_handle.patch --]
[-- Type: text/plain, Size: 1075 bytes --]

>From 7da6d169835acb4aa93bfa48b1ae6b8e198f8e5f Mon Sep 17 00:00:00 2001
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Date: Fri, 19 Feb 2016 09:26:02 -0500
Subject: [PATCH] version: Document guest_handle

And what it is usually used for.

Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Reviewed-by: Razvan Cojocaru <rcojocaru@bitdefender.com>

---
v2: Reword per Jan's suggestion.
---
 xen/include/public/version.h | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/xen/include/public/version.h b/xen/include/public/version.h
index adca602..5e6a7ea 100644
--- a/xen/include/public/version.h
+++ b/xen/include/public/version.h
@@ -78,7 +78,11 @@ typedef struct xen_feature_info xen_feature_info_t;
 /* arg == NULL; returns host memory page size. */
 #define XENVER_pagesize 7
 
-/* arg == xen_domain_handle_t. */
+/* arg == xen_domain_handle_t.
+ *
+ * The toolstack fills it out for guest consumption. It is intended to hold
+ * the UUID of the guest.
+ */
 #define XENVER_guest_handle 8
 
 #define XENVER_commandline 9
-- 
2.1.0


[-- Attachment #3: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [PATCH] version: Document guest_handle

[Jan Beulich]

>>> On 23.02.16 at 20:04, <konrad.wilk@oracle.com> wrote:
> From 7da6d169835acb4aa93bfa48b1ae6b8e198f8e5f Mon Sep 17 00:00:00 2001
> From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> Date: Fri, 19 Feb 2016 09:26:02 -0500
> Subject: [PATCH] version: Document guest_handle
> 
> And what it is usually used for.
> 
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> Reviewed-by: Razvan Cojocaru <rcojocaru@bitdefender.com>
> 
> ---
> v2: Reword per Jan's suggestion.

Acked-by: Jan Beulich <jbeulich@suse.com>