From: Ian Campbell <ian.campbell@citrix.com>
To: ian.jackson@eu.citrix.com, xen-devel@lists.xen.org
Cc: Ian Campbell <ian.campbell@citrix.com>
Subject: [PATCH OSSTEST] sg-report-flight: move "started" column to the left in Step table
Date: Fri, 19 Feb 2016 16:21:44 +0000 [thread overview]
Message-ID: <1455898904-28077-1-git-send-email-ian.campbell@citrix.com> (raw)
With the current ordering of status => started I frequently (more
often than not) read the failing step as "(stepno,testid,script)
failed at <time>" (where <time> is actually the start time, not the
fail time).
Move the "started" column to the left of the "status" column. On the
basis that "(stepno,testid,script) started at $time and failed" reads
more (chrono)logically.
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
sg-report-flight | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/sg-report-flight b/sg-report-flight
index db0d922..99bde92 100755
--- a/sg-report-flight
+++ b/sg-report-flight
@@ -954,8 +954,8 @@ END
</ul>
<h2>Steps</h2>
<table rules=all>
-<tr><th>stepno</th><th>testid</th><th>script</th><th>status</th>
-<th>started</th><th>duration</th></tr>
+<tr><th>stepno</th><th>testid</th><th>script</th><th>started</th>
+<th>status</th><th>duration</th></tr>
END
my %issteplog;
@@ -977,6 +977,8 @@ END
$stepcol->('testid', '');
$stepcol->('step', '');
+ printf H "<td>%s</td>", show_abs_time $step->{started};
+
my $st= $step->{status};
my $logfilename= "$step->{stepno}.$step->{step}.log";
printf H "<td bgcolor='%s'><a href='%s'>%s</a></td>",
@@ -985,8 +987,6 @@ END
encode_entities($st);
$issteplog{$logfilename}= 1;
- printf H "<td>%s</td>", show_abs_time $step->{started};
-
if (defined $step->{finished} && defined $step->{started}) {
printf H "<td align=right>%d</td>\n",
$step->{finished} - $step->{started};
--
2.6.1
reply other threads:[~2016-02-19 16:21 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1455898904-28077-1-git-send-email-ian.campbell@citrix.com \
--to=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).