* [PATCH OSSTEST] sg-report-flight: move "started" column to the left in Step table
@ 2016-02-19 16:21 Ian Campbell
0 siblings, 0 replies; only message in thread
From: Ian Campbell @ 2016-02-19 16:21 UTC (permalink / raw)
To: ian.jackson, xen-devel; +Cc: Ian Campbell
With the current ordering of status => started I frequently (more
often than not) read the failing step as "(stepno,testid,script)
failed at <time>" (where <time> is actually the start time, not the
fail time).
Move the "started" column to the left of the "status" column. On the
basis that "(stepno,testid,script) started at $time and failed" reads
more (chrono)logically.
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
sg-report-flight | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/sg-report-flight b/sg-report-flight
index db0d922..99bde92 100755
--- a/sg-report-flight
+++ b/sg-report-flight
@@ -954,8 +954,8 @@ END
</ul>
<h2>Steps</h2>
<table rules=all>
-<tr><th>stepno</th><th>testid</th><th>script</th><th>status</th>
-<th>started</th><th>duration</th></tr>
+<tr><th>stepno</th><th>testid</th><th>script</th><th>started</th>
+<th>status</th><th>duration</th></tr>
END
my %issteplog;
@@ -977,6 +977,8 @@ END
$stepcol->('testid', '');
$stepcol->('step', '');
+ printf H "<td>%s</td>", show_abs_time $step->{started};
+
my $st= $step->{status};
my $logfilename= "$step->{stepno}.$step->{step}.log";
printf H "<td bgcolor='%s'><a href='%s'>%s</a></td>",
@@ -985,8 +987,6 @@ END
encode_entities($st);
$issteplog{$logfilename}= 1;
- printf H "<td>%s</td>", show_abs_time $step->{started};
-
if (defined $step->{finished} && defined $step->{started}) {
printf H "<td align=right>%d</td>\n",
$step->{finished} - $step->{started};
--
2.6.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2016-02-19 16:21 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-19 16:21 [PATCH OSSTEST] sg-report-flight: move "started" column to the left in Step table Ian Campbell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).