From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: [PATCH OSSTEST] sg-report-flight: move "started" column
	to the left in Step table
Date: Fri, 19 Feb 2016 16:21:44 +0000
Message-ID: <1455898904-28077-1-git-send-email-ian.campbell@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: ian.jackson@eu.citrix.com, xen-devel@lists.xen.org
Cc: Ian Campbell <ian.campbell@citrix.com>
List-Id: xen-devel@lists.xenproject.org

With the current ordering of status => started I frequently (more
often than not) read the failing step as "(stepno,testid,script)
failed at <time>" (where <time> is actually the start time, not the
fail time).

Move the "started" column to the left of the "status" column. On the
basis that "(stepno,testid,script) started at $time and failed" reads
more (chrono)logically.

Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
 sg-report-flight | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/sg-report-flight b/sg-report-flight
index db0d922..99bde92 100755
--- a/sg-report-flight
+++ b/sg-report-flight
@@ -954,8 +954,8 @@ END
 </ul>
 <h2>Steps</h2>
 <table rules=all>
-<tr><th>stepno</th><th>testid</th><th>script</th><th>status</th>
-<th>started</th><th>duration</th></tr>
+<tr><th>stepno</th><th>testid</th><th>script</th><th>started</th>
+<th>status</th><th>duration</th></tr>
 END
 
     my %issteplog;
@@ -977,6 +977,8 @@ END
         $stepcol->('testid', '');
         $stepcol->('step', '');
 
+        printf H "<td>%s</td>", show_abs_time $step->{started};
+
         my $st= $step->{status};
         my $logfilename= "$step->{stepno}.$step->{step}.log";
         printf H "<td bgcolor='%s'><a href='%s'>%s</a></td>",
@@ -985,8 +987,6 @@ END
             encode_entities($st);
         $issteplog{$logfilename}= 1;
 
-        printf H "<td>%s</td>", show_abs_time $step->{started};
-
 	if (defined $step->{finished} && defined $step->{started}) {
 	    printf H "<td align=right>%d</td>\n",
                 $step->{finished} - $step->{started};
-- 
2.6.1