xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xen.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	Stefano Stabellini <stefano.stabellini@citrix.com>,
	Ian Campbell <ian.campbell@citrix.com>,
	Jan Beulich <JBeulich@suse.com>
Subject: [PATCH v2 1/8] xen/lockprof: Move .lockprofile.data into .rodata
Date: Tue, 23 Feb 2016 16:31:18 +0000	[thread overview]
Message-ID: <1456245085-2302-2-git-send-email-andrew.cooper3@citrix.com> (raw)
In-Reply-To: <1456245085-2302-1-git-send-email-andrew.cooper3@citrix.com>

The entire contents of .lockprofile.data are unchanging pointers to
lock_profile structure in .data.  Annotate the type as such, and link the
section in .rodata.  As these are just pointers, there is no need for 32byte
alignment.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Ian Campbell <ian.campbell@citrix.com>
CC: Stefano Stabellini <stefano.stabellini@citrix.com>

New in v2
---
 xen/arch/arm/xen.lds.S     | 14 +++++++-------
 xen/arch/x86/xen.lds.S     | 13 ++++++-------
 xen/include/xen/spinlock.h |  2 +-
 3 files changed, 14 insertions(+), 15 deletions(-)

diff --git a/xen/arch/arm/xen.lds.S b/xen/arch/arm/xen.lds.S
index f501a2f..6bbfba1 100644
--- a/xen/arch/arm/xen.lds.S
+++ b/xen/arch/arm/xen.lds.S
@@ -50,6 +50,13 @@ SECTIONS
        __stop_bug_frames_2 = .;
        *(.rodata)
        *(.rodata.*)
+
+#ifdef LOCK_PROFILE
+       __lock_profile_start = .;
+       *(.lockprofile.data)
+       __lock_profile_end = .;
+#endif
+
         _erodata = .;          /* End of read-only data */
   } :text
 
@@ -83,13 +90,6 @@ SECTIONS
        *(.data.rel.ro.*)
   } :text
 
-#ifdef LOCK_PROFILE
-  . = ALIGN(32);
-  __lock_profile_start = .;
-  .lockprofile.data : { *(.lockprofile.data) } :text
-  __lock_profile_end = .;
-#endif
-
   . = ALIGN(8);
   .arch.info : {
       _splatform = .;
diff --git a/xen/arch/x86/xen.lds.S b/xen/arch/x86/xen.lds.S
index 9fde1db..106067a 100644
--- a/xen/arch/x86/xen.lds.S
+++ b/xen/arch/x86/xen.lds.S
@@ -65,6 +65,12 @@ SECTIONS
 
        *(.rodata)
        *(.rodata.*)
+
+#ifdef LOCK_PROFILE
+       __lock_profile_start = .;
+       *(.lockprofile.data)
+       __lock_profile_end = .;
+#endif
   } :text
 
   . = ALIGN(SMP_CACHE_BYTES);
@@ -97,13 +103,6 @@ SECTIONS
        CONSTRUCTORS
   } :text
 
-#ifdef LOCK_PROFILE
-  . = ALIGN(32);
-  __lock_profile_start = .;
-  .lockprofile.data : { *(.lockprofile.data) } :text
-  __lock_profile_end = .;
-#endif
-
   . = ALIGN(PAGE_SIZE);             /* Init code and data */
   __init_begin = .;
   .init.text : {
diff --git a/xen/include/xen/spinlock.h b/xen/include/xen/spinlock.h
index 77ab7d5..88b53f9 100644
--- a/xen/include/xen/spinlock.h
+++ b/xen/include/xen/spinlock.h
@@ -79,7 +79,7 @@ struct lock_profile_qhead {
 
 #define _LOCK_PROFILE(name) { 0, #name, &name, 0, 0, 0, 0, 0 }
 #define _LOCK_PROFILE_PTR(name)                                               \
-    static struct lock_profile *__lock_profile_##name                         \
+    static struct lock_profile * const __lock_profile_##name                  \
     __used_section(".lockprofile.data") =                                     \
     &__lock_profile_data_##name
 #define _SPIN_LOCK_UNLOCKED(x) { { 0 }, SPINLOCK_NO_CPU, 0, _LOCK_DEBUG, x }
-- 
2.1.4

  reply	other threads:[~2016-02-23 16:31 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-23 16:31 [PATCH v2 0/8] Map Xen code/data/bss with superpages Andrew Cooper
2016-02-23 16:31 ` Andrew Cooper [this message]
2016-02-24 11:16   ` [PATCH v2 1/8] xen/lockprof: Move .lockprofile.data into .rodata Jan Beulich
2016-02-23 16:31 ` [PATCH v2 2/8] xen/x86: Improvements to build-time pagetable generation Andrew Cooper
2016-02-24 11:24   ` Jan Beulich
2016-02-24 13:57     ` Andrew Cooper
2016-02-24 14:15       ` Jan Beulich
2016-02-24 14:58         ` Andrew Cooper
2016-02-24 15:18           ` Jan Beulich
2016-02-24 15:22             ` Andrew Cooper
2016-02-24 15:48               ` Jan Beulich
2016-02-24 16:14                 ` Andrew Cooper
2016-02-24 16:59                   ` Jan Beulich
2016-02-24 17:28                     ` Andrew Cooper
2016-02-23 16:31 ` [PATCH v2 3/8] xen/x86: Construct the {l2, l3}_bootmap at compile time Andrew Cooper
2016-02-24 11:34   ` Jan Beulich
2016-02-24 11:40     ` Andrew Cooper
2016-02-24 11:50       ` Jan Beulich
2016-02-24 12:07         ` Andrew Cooper
2016-02-23 16:31 ` [PATCH v2 4/8] xen/memguard: Drop memguard_init() entirely Andrew Cooper
2016-02-24 13:26   ` Jan Beulich
2016-02-24 15:02     ` Stefano Stabellini
2016-02-23 16:31 ` [PATCH v2 5/8] xen/x86: Disable CR0.WP while applying alternatives Andrew Cooper
2016-02-23 16:31 ` [PATCH v2 6/8] xen/x86: Reorder .data and .init when linking Andrew Cooper
2016-02-24 11:41   ` Jan Beulich
2016-02-24 11:44     ` Andrew Cooper
2016-02-23 16:31 ` [PATCH v2 7/8] xen/x86: Use 2M superpages for text/data/bss mappings Andrew Cooper
2016-02-24 13:17   ` Jan Beulich
2016-02-24 13:21     ` Andrew Cooper
2016-02-24 13:23       ` Andrew Cooper
2016-02-23 16:31 ` [PATCH v2 8/8] xen/x86: Unilaterally remove .init mappings Andrew Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1456245085-2302-2-git-send-email-andrew.cooper3@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=ian.campbell@citrix.com \
    --cc=stefano.stabellini@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).