From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH] xl: Improve return and exit codes of parse_config_data(). Date: Tue, 23 Feb 2016 19:20:56 +0100 Message-ID: <1456251656.17312.11.camel@citrix.com> References: <1455899846-4146-1-git-send-email-write.harmandeep@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5547722701630675103==" Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aYHa6-0002LX-AZ for xen-devel@lists.xenproject.org; Tue, 23 Feb 2016 18:21:06 +0000 In-Reply-To: <1455899846-4146-1-git-send-email-write.harmandeep@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Harmandeep Kaur , xen-devel@lists.xenproject.org Cc: wei.liu2@citrix.com, ian.jackson@eu.citrix.com, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org --===============5547722701630675103== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-cTExoXNT33lTBnCCYW8/" --=-cTExoXNT33lTBnCCYW8/ Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2016-02-19 at 22:07 +0530, Harmandeep Kaur wrote: > Turning parse_config_data() exit codes towards using the > EXIT_[SUCCESS|FAILURE] constants, instead of instead of arbitrary > repetition of "instead of" > numbers or libxl return codes. > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0- for main_*: arbitrary -= > EXIT_SUCCESS|EXIT_FAILURE. > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0- for internal fucntion: = arbitrary -> 0/1. > This is what you've done in other similar patches, and what should be done in general. In the case of this patch, only one function is being considered, and it's an internal void function, i.e., there's no 'internal returns', but only calls to exit(). This changelog should be made a little bit more specific, and say the above (or maybe just leave the first paragraph there, and remove the rest). Apart from this, the code looks ok to me. So, with these changes, this patch is: > Signed-off-by: Harmandeep Kaur > Reviewed-by: Dario Faggioli Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-cTExoXNT33lTBnCCYW8/ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEABECAAYFAlbMowgACgkQk4XaBE3IOsSztwCfdfhnMssmp31Hxd6qkU/unDCq MUoAniyNvr2Viocc7dZoPdjta3u90BFc =/TIe -----END PGP SIGNATURE----- --=-cTExoXNT33lTBnCCYW8/-- --===============5547722701630675103== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============5547722701630675103==--