From mboxrd@z Thu Jan 1 00:00:00 1970 From: Harmandeep Kaur Subject: [PATCH 9/9] xl: Improve return codes of main_domid(), main_domname() and main_sysrq() and related functions. Date: Wed, 24 Feb 2016 18:23:27 +0530 Message-ID: <1456318407-3635-10-git-send-email-write.harmandeep@gmail.com> References: <1456318407-3635-1-git-send-email-write.harmandeep@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aYYxo-0008Ji-PV for xen-devel@lists.xenproject.org; Wed, 24 Feb 2016 12:54:44 +0000 Received: by mail-pf0-f194.google.com with SMTP id c10so918584pfc.0 for ; Wed, 24 Feb 2016 04:54:42 -0800 (PST) In-Reply-To: <1456318407-3635-1-git-send-email-write.harmandeep@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xenproject.org Cc: wei.liu2@citrix.com, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, dario.faggioli@citrix.com, ian.jackson@eu.citrix.com, Harmandeep Kaur List-Id: xen-devel@lists.xenproject.org Signed-off-by: Harmandeep Kaur --- tools/libxl/xl_cmdimpl.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c index 9e0a467..234977c 100644 --- a/tools/libxl/xl_cmdimpl.c +++ b/tools/libxl/xl_cmdimpl.c @@ -6320,12 +6320,12 @@ int main_domid(int argc, char **argv) if (libxl_name_to_domid(ctx, domname, &domid)) { fprintf(stderr, "Can't get domid of domain name '%s', maybe this domain does not exist.\n", domname); - return 1; + return EXIT_FAILURE; } printf("%d\n", domid); - return 0; + return EXIT_SUCCESS; } int main_domname(int argc, char **argv) @@ -6343,13 +6343,13 @@ int main_domname(int argc, char **argv) if (domid == 0 && !strcmp(endptr, argv[optind])) { /*no digits at all*/ fprintf(stderr, "Invalid domain id.\n\n"); - return 1; + return EXIT_FAILURE; } domname = libxl_domid_to_name(ctx, domid); if (!domname) { fprintf(stderr, "Can't get domain name of domain id '%d', maybe this domain does not exist.\n", domid); - return 1; + return EXIT_SUCCESS; } printf("%s\n", domname); @@ -6431,12 +6431,12 @@ int main_sysrq(int argc, char **argv) if (sysrq[1] != '\0') { fprintf(stderr, "Invalid sysrq.\n\n"); help("sysrq"); - return 1; + return EXIT_FAILURE; } libxl_send_sysrq(ctx, domid, sysrq[0]); - return 0; + return EXIT_SUCCESS; } int main_debug_keys(int argc, char **argv) -- 2.5.0