From mboxrd@z Thu Jan 1 00:00:00 1970 From: Harmandeep Kaur Subject: [PATCH 6/9] xl: Improve return and exit codes of main_list() and main_vm_list() related functions. Date: Wed, 24 Feb 2016 18:23:24 +0530 Message-ID: <1456318407-3635-7-git-send-email-write.harmandeep@gmail.com> References: <1456318407-3635-1-git-send-email-write.harmandeep@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aYYxd-00088v-4A for xen-devel@lists.xenproject.org; Wed, 24 Feb 2016 12:54:33 +0000 Received: by mail-pa0-f66.google.com with SMTP id a7so872384pax.3 for ; Wed, 24 Feb 2016 04:54:31 -0800 (PST) In-Reply-To: <1456318407-3635-1-git-send-email-write.harmandeep@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xenproject.org Cc: wei.liu2@citrix.com, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, dario.faggioli@citrix.com, ian.jackson@eu.citrix.com, Harmandeep Kaur List-Id: xen-devel@lists.xenproject.org Signed-off-by: Harmandeep Kaur --- tools/libxl/xl_cmdimpl.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c index b4920ff..9d95b50 100644 --- a/tools/libxl/xl_cmdimpl.c +++ b/tools/libxl/xl_cmdimpl.c @@ -433,7 +433,7 @@ static void flush_stream(FILE *fh) if (ferror(fh) || fflush(fh)) { perror(fh_name); - exit(-1); + exit(EXIT_FAILURE); } } @@ -3927,12 +3927,12 @@ static void list_domains(bool verbose, bool context, bool claim, bool numa, if (numa) { if (libxl_node_bitmap_alloc(ctx, &nodemap, 0)) { fprintf(stderr, "libxl_node_bitmap_alloc_failed.\n"); - exit(1); + exit(EXIT_FAILURE); } if (libxl_get_physinfo(ctx, &physinfo) != 0) { fprintf(stderr, "libxl_physinfo failed.\n"); libxl_bitmap_dispose(&nodemap); - exit(1); + exit(EXIT_FAILURE); } printf(" NODE Affinity"); @@ -3996,7 +3996,7 @@ static void list_vm(void) if (!info) { fprintf(stderr, "libxl_list_vm failed.\n"); - exit(1); + exit(EXIT_FAILURE); } printf("UUID ID name\n"); for (i = 0; i < nb_vm; i++) { @@ -4944,7 +4944,7 @@ int main_list(int argc, char **argv) info = libxl_list_domain(ctx, &nb_domain); if (!info) { fprintf(stderr, "libxl_list_domain failed.\n"); - return 1; + return EXIT_FAILURE; } info_free = info; } else if (optind == argc-1) { @@ -4953,17 +4953,17 @@ int main_list(int argc, char **argv) if (rc == ERROR_DOMAIN_NOTFOUND) { fprintf(stderr, "Error: Domain \'%s\' does not exist.\n", argv[optind]); - return -rc; + return EXIT_FAILURE; } if (rc) { fprintf(stderr, "libxl_domain_info failed (code %d).\n", rc); - return -rc; + return EXIT_FAILURE; } info = &info_buf; nb_domain = 1; } else { help("list"); - return 2; + return EXIT_FAILURE; } if (details) @@ -4977,7 +4977,7 @@ int main_list(int argc, char **argv) libxl_dominfo_dispose(&info_buf); - return 0; + return EXIT_SUCCESS; } int main_vm_list(int argc, char **argv) @@ -4989,7 +4989,7 @@ int main_vm_list(int argc, char **argv) } list_vm(); - return 0; + return EXIT_SUCCESS; } static void string_realloc_append(char **accumulate, const char *more) -- 2.5.0