From mboxrd@z Thu Jan 1 00:00:00 1970 From: Harmandeep Kaur Subject: [PATCH 8/9] xl: Improve return and exit codes main_button_press(), main_trigger(), main_remus() and related functions. Date: Wed, 24 Feb 2016 18:23:26 +0530 Message-ID: <1456318407-3635-9-git-send-email-write.harmandeep@gmail.com> References: <1456318407-3635-1-git-send-email-write.harmandeep@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aYYxk-0008FL-M9 for xen-devel@lists.xenproject.org; Wed, 24 Feb 2016 12:54:40 +0000 Received: by mail-pf0-f194.google.com with SMTP id e127so915139pfe.3 for ; Wed, 24 Feb 2016 04:54:38 -0800 (PST) In-Reply-To: <1456318407-3635-1-git-send-email-write.harmandeep@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xenproject.org Cc: wei.liu2@citrix.com, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, dario.faggioli@citrix.com, ian.jackson@eu.citrix.com, Harmandeep Kaur List-Id: xen-devel@lists.xenproject.org Signed-off-by: Harmandeep Kaur --- tools/libxl/xl_cmdimpl.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c index f7f7d7f..9e0a467 100644 --- a/tools/libxl/xl_cmdimpl.c +++ b/tools/libxl/xl_cmdimpl.c @@ -374,7 +374,7 @@ static void xvasprintf(char **strp, const char *fmt, va_list ap) int r = vasprintf(strp, fmt, ap); if (r == -1) { perror("asprintf failed"); - exit(-ERROR_FAIL); + exit(EXIT_FAILURE); } } @@ -5216,7 +5216,7 @@ static void button_press(uint32_t domid, const char *b) trigger = LIBXL_TRIGGER_SLEEP; } else { fprintf(stderr, "%s is an invalid button identifier\n", b); - exit(2); + exit(EXIT_FAILURE); } libxl_send_trigger(ctx, domid, trigger, 0); @@ -6398,7 +6398,7 @@ int main_trigger(int argc, char **argv) trigger_name = argv[optind++]; if (libxl_trigger_from_string(trigger_name, &trigger)) { fprintf(stderr, "Invalid trigger \"%s\"\n", trigger_name); - return -1; + return EXIT_FAILURE; } if (argv[optind]) { @@ -6410,7 +6410,7 @@ int main_trigger(int argc, char **argv) libxl_send_trigger(ctx, domid, trigger, vcpuid); - return 0; + return EXIT_SUCCESS; } @@ -8064,7 +8064,7 @@ int main_remus(int argc, char **argv) send_fd = open("/dev/null", O_RDWR, 0644); if (send_fd < 0) { perror("failed to open /dev/null"); - exit(-1); + exit(EXIT_FAILURE); } } else { @@ -8081,7 +8081,7 @@ int main_remus(int argc, char **argv) if (!config_len) { fprintf(stderr, "No config file stored for running domain and " "none supplied - cannot start remus.\n"); - exit(1); + exit(EXIT_FAILURE); } child = create_migration_child(rune, &send_fd, &recv_fd); @@ -8102,7 +8102,7 @@ int main_remus(int argc, char **argv) if (libxl_domain_info(ctx, 0, domid)) { fprintf(stderr, "Remus: Primary domain has been destroyed.\n"); close(send_fd); - return 0; + return EXIT_SUCCESS; } /* If we are here, it means remus setup/domain suspend/backup has @@ -8117,7 +8117,7 @@ int main_remus(int argc, char **argv) } close(send_fd); - return -ERROR_FAIL; + return EXIT_FAILURE; } #endif -- 2.5.0