From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH 1/9] xl: Improve return and exit codes of memory related functions. Date: Wed, 24 Feb 2016 15:30:28 +0100 Message-ID: <1456324228.17312.62.camel@citrix.com> References: <1456318407-3635-1-git-send-email-write.harmandeep@gmail.com> <1456318407-3635-2-git-send-email-write.harmandeep@gmail.com> <20160224135537.GA32763@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4380780475284492329==" Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aYaSa-0006ES-1W for xen-devel@lists.xenproject.org; Wed, 24 Feb 2016 14:30:36 +0000 In-Reply-To: <20160224135537.GA32763@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Olaf Hering , Harmandeep Kaur Cc: ian.jackson@eu.citrix.com, xen-devel@lists.xenproject.org, wei.liu2@citrix.com, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org --===============4380780475284492329== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-hURR4zSj/Vw/Z9TF4pzS" --=-hURR4zSj/Vw/Z9TF4pzS Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2016-02-24 at 14:55 +0100, Olaf Hering wrote: > On Wed, Feb 24, Harmandeep Kaur wrote: >=20 > > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0exit(2); > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0exit(EXIT_FAILURE); >=20 > The commit message should state why changing the value is fine. > I dont know if anyone actually cares about the exact value. >=20 This has been discussed before here on the mailing list, and there already are patches committed that do this same thing in a bunch of cases (and, of course, the aim is consistently doing it everywhere). Previous discussion is here: =C2=A0http://lists.xen.org/archives/html/xen-devel/2015-10/msg02497.html =C2=A0http://lists.xen.org/archives/html/xen-devel/2015-10/msg02501.html =C2=A0http://lists.xen.org/archives/html/xen-devel/2015-10/msg02509.html And, even before, here: =C2=A0http://lists.xenproject.org/archives/html/xen-devel/2015-03/msg01336.= html =C2=A0http://lists.xenproject.org/archives/html/xen-devel/2015-03/msg01341.= html I'm quit sure there is no one doing anything useful with exit codes right now, as they're so inconsistent that it would just be plain impossible! :-) Anyway, Harmandeep, can you summarize better (and maybe reference) these previous discussions and your previous related work in the cover letter of this series (and any other similar one that may follow)? Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-hURR4zSj/Vw/Z9TF4pzS Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEABECAAYFAlbNvoQACgkQk4XaBE3IOsQB+QCgiZp9S82h4KnznY8YXmw45YGO eW4An0Bsu1JzWxtyBQrrhAsg3Dx+x/5h =B3Vn -----END PGP SIGNATURE----- --=-hURR4zSj/Vw/Z9TF4pzS-- --===============4380780475284492329== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============4380780475284492329==--