From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH 9/9] xl: Improve return codes of main_domid(), main_domname() and main_sysrq() and related functions. Date: Thu, 25 Feb 2016 12:18:56 +0100 Message-ID: <1456399136.6288.88.camel@citrix.com> References: <1456318407-3635-1-git-send-email-write.harmandeep@gmail.com> <1456318407-3635-10-git-send-email-write.harmandeep@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1574720639701049772==" Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.84) (envelope-from ) id 1aYtwk-0005XK-C1 for xen-devel@lists.xenproject.org; Thu, 25 Feb 2016 11:19:02 +0000 In-Reply-To: <1456318407-3635-10-git-send-email-write.harmandeep@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Harmandeep Kaur , xen-devel@lists.xenproject.org Cc: wei.liu2@citrix.com, ian.jackson@eu.citrix.com, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org --===============1574720639701049772== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-fEgtOxyNlynIji4Ppql5" --=-fEgtOxyNlynIji4Ppql5 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2016-02-24 at 18:23 +0530, Harmandeep Kaur wrote: > Signed-off-by: Harmandeep Kaur > So, this basically is "domain id and name related functions", or "domain utility functions". I'd rename the patch with something like that. Also, I think find_domain() is fits nicely in here. > --- > =C2=A0tools/libxl/xl_cmdimpl.c | 12 ++++++------ > =C2=A01 file changed, 6 insertions(+), 6 deletions(-) >=20 > diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c > index 9e0a467..234977c 100644 > --- a/tools/libxl/xl_cmdimpl.c > +++ b/tools/libxl/xl_cmdimpl.c > =C2=A0int main_domname(int argc, char **argv) > @@ -6343,13 +6343,13 @@ int main_domname(int argc, char **argv) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0if (domid =3D=3D 0 && !strcmp(endptr, argv[= optind])) { > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0/*no digits at all*= / > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0fprintf(stderr, "In= valid domain id.\n\n"); > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0return 1; > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0return EXIT_FAILURE; > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0} > =C2=A0 > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0domname =3D libxl_domid_to_name(ctx, domid)= ; > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0if (!domname) { > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0fprintf(stderr, "Ca= n't get domain name of domain id '%d', > maybe this domain does not exist.\n", domid); > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0return 1; > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0return EXIT_SUCCESS; > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0} > =C2=A0 > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0printf("%s\n", domname); > main_rename() can well be done in this patch as well. > @@ -6431,12 +6431,12 @@ int main_sysrq(int argc, char **argv) > While this one, I'd do it in another patch. (I'd probably move it to patch 8) Thanks and Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-fEgtOxyNlynIji4Ppql5 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEABECAAYFAlbO4yAACgkQk4XaBE3IOsS9FgCfanWJanWmGXNGiB9A0xIHJ4jE qwMAn0wxP2zzOUH64yyGqXwKokbOHN5D =D4Pw -----END PGP SIGNATURE----- --=-fEgtOxyNlynIji4Ppql5-- --===============1574720639701049772== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y Zy94ZW4tZGV2ZWwK --===============1574720639701049772==--