From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH 4/9] xl: Improve return and exit codes of main_console(), main_vncviewer() and main_dump_core(). Date: Thu, 25 Feb 2016 12:33:05 +0100 Message-ID: <1456399985.6288.99.camel@citrix.com> References: <1456318407-3635-1-git-send-email-write.harmandeep@gmail.com> <1456318407-3635-5-git-send-email-write.harmandeep@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2244469529830165486==" Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.84) (envelope-from ) id 1aYuAS-0007ww-4Y for xen-devel@lists.xenproject.org; Thu, 25 Feb 2016 11:33:12 +0000 In-Reply-To: <1456318407-3635-5-git-send-email-write.harmandeep@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Harmandeep Kaur , xen-devel@lists.xenproject.org Cc: wei.liu2@citrix.com, ian.jackson@eu.citrix.com, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org --===============2244469529830165486== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-3hXXo4s+6suvWwvmKuzs" --=-3hXXo4s+6suvWwvmKuzs Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2016-02-24 at 18:23 +0530, Harmandeep Kaur wrote: > Signed-off-by: Harmandeep Kaur > "console, vnc and core dump related function" I'm not sure I'd put main_dump_core() in this patch, rather than in patch 8, but I think it's just fine wither way. > diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c >=C2=A0 > @@ -3457,8 +3457,8 @@ int main_vncviewer(int argc, char **argv) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0domid =3D find_domain(argv[optind]); > =C2=A0 > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0if (vncviewer(domid, autopass)) > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0return 1; > -=C2=A0=C2=A0=C2=A0=C2=A0return 0; > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0return EXIT_FAILURE; > +=C2=A0=C2=A0=C2=A0=C2=A0return EXIT_SUCCESS; > Have a look at=C2=A0vncviewer() and=C2=A0autoconnect_vncviewer() too. Thanks and Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-3hXXo4s+6suvWwvmKuzs Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEABECAAYFAlbO5nIACgkQk4XaBE3IOsSw3gCeP5nP09a7cm8giks2SiIgtyRB j4YAn3AzNeSam+aBVYvGgdEfeqHsXQCx =lxMA -----END PGP SIGNATURE----- --=-3hXXo4s+6suvWwvmKuzs-- --===============2244469529830165486== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y Zy94ZW4tZGV2ZWwK --===============2244469529830165486==--