From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH RFC 0/8] x86/hvm, libxl: HVM SMT topology support Date: Fri, 26 Feb 2016 16:03:46 +0100 Message-ID: <1456499026.2959.195.camel@citrix.com> References: <1456174934-22973-1-git-send-email-joao.m.martins@oracle.com> <56CF3822.80606@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5195805880497480378==" Return-path: In-Reply-To: <56CF3822.80606@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Andrew Cooper , Joao Martins , xen-devel@lists.xen.org Cc: Elena Ufimtseva , Wei Liu , Stefano Stabellini , Ian Jackson , Jan Beulich , Keir Fraser List-Id: xen-devel@lists.xenproject.org --===============5195805880497480378== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-veOQtJkXW2My+fTJS/mA" --=-veOQtJkXW2My+fTJS/mA Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2016-02-25 at 17:21 +0000, Andrew Cooper wrote: > On 22/02/16 21:02, Joao Martins wrote: > >=C2=A0 > > Any comments are appreciated! > Hey.=C2=A0=C2=A0Sorry I am late getting to this - I am currently swamped.= =C2=A0=C2=A0Some > general observations. >=20 Hi, I'm also looking forward to find the time to look at this series, but that will have to wait a few days more, I'm afraid. However, one thing (coming from Andrew's comment). > As part of my further cpuid work, I will need to fix this.=C2=A0=C2=A0I w= as > planning to fix it by requiring full cpu topology information to be > passed as part of the domaincreate or max_vcpus hypercall=C2=A0=C2=A0(not > chosen > which yet).=C2=A0=C2=A0 > If that means that, when creating a multi vcpus guest, it will be necessary to provide Xen with all the information about the relationship between these multiple vcpus (and that there will be some sensible default, of course), this would be *awesome*. :-) At that point, one can just build on top of that, in order to achieve something like what is implemented in this series, or any other variant of it, which would indeed be *awesome* (did I said that already? :-D). Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-veOQtJkXW2My+fTJS/mA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEABECAAYFAlbQaVIACgkQk4XaBE3IOsTCsACgmU28bH66B3UrcTlPxiMkpVSI KNgAmwQW7EUvEzotlDGaIgcXyRQe6yxp =ewrP -----END PGP SIGNATURE----- --=-veOQtJkXW2My+fTJS/mA-- --===============5195805880497480378== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y Zy94ZW4tZGV2ZWwK --===============5195805880497480378==--