From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xen.org
Cc: Juergen Gross <jgross@suse.com>,
wei.liu2@citrix.com, stefano.stabellini@eu.citrix.com,
george.dunlap@eu.citrix.com, andrew.cooper3@citrix.com,
dario.faggioli@citrix.com, ian.jackson@eu.citrix.com,
david.vrabel@citrix.com, jbeulich@suse.com
Subject: [PATCH v2 1/3] xen: silence affinity messages on suspend/resume
Date: Tue, 1 Mar 2016 10:02:11 +0100 [thread overview]
Message-ID: <1456822933-25041-2-git-send-email-jgross@suse.com> (raw)
In-Reply-To: <1456822933-25041-1-git-send-email-jgross@suse.com>
When taking cpus offline for suspend or bringing them online on resume
again the scheduler might issue debug messages when temporarily
breaking vcpu affinity or restoring the original affinity settings.
The resume message can be removed completely, while the message when
breaking affinity should only be issued if the breakage is permanent.
Suggested-by: Jan Beulich <jbeulich@suse.com>
Signed-off-by: Juergen Gross <jgross@suse.com>
---
xen/common/schedule.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/xen/common/schedule.c b/xen/common/schedule.c
index 434dcfc..b0d4b18 100644
--- a/xen/common/schedule.c
+++ b/xen/common/schedule.c
@@ -615,7 +615,6 @@ void restore_vcpu_affinity(struct domain *d)
if ( v->affinity_broken )
{
- printk(XENLOG_DEBUG "Restoring affinity for %pv\n", v);
cpumask_copy(v->cpu_hard_affinity, v->cpu_hard_affinity_saved);
v->affinity_broken = 0;
}
@@ -670,14 +669,14 @@ int cpu_disable_scheduler(unsigned int cpu)
if ( cpumask_empty(&online_affinity) &&
cpumask_test_cpu(cpu, v->cpu_hard_affinity) )
{
- printk(XENLOG_DEBUG "Breaking affinity for %pv\n", v);
-
if (system_state == SYS_STATE_suspend)
{
cpumask_copy(v->cpu_hard_affinity_saved,
v->cpu_hard_affinity);
v->affinity_broken = 1;
}
+ else
+ printk(XENLOG_DEBUG "Breaking affinity for %pv\n", v);
cpumask_setall(v->cpu_hard_affinity);
}
--
2.6.2
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-03-01 9:02 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 9:02 [PATCH v2 0/3] add hypercall option to temporarily pin a vcpu Juergen Gross
2016-03-01 9:02 ` Juergen Gross [this message]
2016-03-02 11:11 ` [PATCH v2 1/3] xen: silence affinity messages on suspend/resume Dario Faggioli
2016-03-01 9:02 ` [PATCH v2 2/3] xen: add hypercall option to temporarily pin a vcpu Juergen Gross
2016-03-01 11:27 ` Jan Beulich
2016-03-01 11:55 ` David Vrabel
2016-03-01 11:58 ` Juergen Gross
2016-03-01 12:15 ` Dario Faggioli
2016-03-01 14:02 ` George Dunlap
[not found] ` <56D58ABF02000078000D7C46@suse.com>
2016-03-01 11:58 ` Juergen Gross
2016-03-01 15:52 ` George Dunlap
2016-03-01 15:55 ` George Dunlap
2016-03-01 16:11 ` Jan Beulich
2016-03-02 7:14 ` Juergen Gross
2016-03-02 9:27 ` Dario Faggioli
2016-03-02 11:19 ` Juergen Gross
2016-03-02 11:49 ` Dario Faggioli
2016-03-02 12:12 ` Juergen Gross
2016-03-02 15:34 ` Juergen Gross
2016-03-02 16:03 ` Dario Faggioli
2016-03-02 17:15 ` Juergen Gross
2016-03-02 17:21 ` Anshul Makkar
2016-03-03 5:31 ` Juergen Gross
2016-03-01 9:02 ` [PATCH v2 3/3] libxc: do some retries in xc_cpupool_removecpu() for EBUSY case Juergen Gross
2016-03-01 11:58 ` Wei Liu
2016-03-01 11:59 ` Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456822933-25041-2-git-send-email-jgross@suse.com \
--to=jgross@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=dario.faggioli@citrix.com \
--cc=david.vrabel@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).