From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH 5/9] xl: Improve return and exit codes of main_pause(), main_unpause(), main_destroy() and main_shutdown_or_reboot() related functions. Date: Wed, 2 Mar 2016 17:59:00 +0100 Message-ID: <1456937940.2959.380.camel@citrix.com> References: <1456318407-3635-1-git-send-email-write.harmandeep@gmail.com> <1456318407-3635-6-git-send-email-write.harmandeep@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3385803094771185660==" Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.84) (envelope-from ) id 1abA7l-0004Cz-MR for xen-devel@lists.xenproject.org; Wed, 02 Mar 2016 16:59:45 +0000 In-Reply-To: <1456318407-3635-6-git-send-email-write.harmandeep@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Harmandeep Kaur , xen-devel@lists.xenproject.org Cc: wei.liu2@citrix.com, ian.jackson@eu.citrix.com, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org --===============3385803094771185660== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-hhG9ySQ3oQP88vbX9Gd1" --=-hhG9ySQ3oQP88vbX9Gd1 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2016-02-24 at 18:23 +0530, Harmandeep Kaur wrote: > Signed-off-by: Harmandeep Kaur > Apart from the subject that, as said already, should be more generic, and from (at least) one long line, this patch looks fine to me. I'd provide my Reviewed-by, but I asked to move some hunks from patch 4/9 to here, so that would not apply to next version anyway. In any case, as said, as far as these modification go, they're fine. Thanks and Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-hhG9ySQ3oQP88vbX9Gd1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEABECAAYFAlbXG9QACgkQk4XaBE3IOsSAXwCfeKVkA0urC+I9Bx57xaSsoVQj kPAAnjT38d9O9DyHp8tiFkQOv5cs9XVt =2f/Z -----END PGP SIGNATURE----- --=-hhG9ySQ3oQP88vbX9Gd1-- --===============3385803094771185660== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y Zy94ZW4tZGV2ZWwK --===============3385803094771185660==--