From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH 7/9] xl: Improve return and exit codes of
 main_create(), main_config_update(), main_sharing(),
 main_rename() and related functions.
Date: Wed, 2 Mar 2016 18:29:14 +0100
Message-ID: <1456939754.2959.383.camel@citrix.com>
References: <1456318407-3635-1-git-send-email-write.harmandeep@gmail.com>
 <1456318407-3635-8-git-send-email-write.harmandeep@gmail.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4299096529413697033=="
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
 by lists.xen.org with esmtp (Exim 4.84)
 (envelope-from <prvs=8628d4685=dario.faggioli@citrix.com>)
 id 1abAar-0006rk-Gq
 for xen-devel@lists.xenproject.org; Wed, 02 Mar 2016 17:29:49 +0000
In-Reply-To: <1456318407-3635-8-git-send-email-write.harmandeep@gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xen.org
Sender: "Xen-devel" <xen-devel-bounces@lists.xen.org>
To: Harmandeep Kaur <write.harmandeep@gmail.com>, xen-devel@lists.xenproject.org
Cc: wei.liu2@citrix.com, ian.jackson@eu.citrix.com, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com
List-Id: xen-devel@lists.xenproject.org

--===============4299096529413697033==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-y/qK2h4CqUeW9APFIkdZ"

--=-y/qK2h4CqUeW9APFIkdZ
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, 2016-02-24 at 18:23 +0530, Harmandeep Kaur wrote:
> Signed-off-by: Harmandeep Kaur <write.harmandeep@gmail.com>
>
I don't recall if I said this already, but main_sharing() does not
belong here.
=C2=A0
> @@ -5095,11 +5095,11 @@ int main_create(int argc, char **argv)
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0rc =3D create_domain(&dom_info);
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0if (rc < 0) {
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0free(dom_info.extra=
_config);
> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0return -rc;
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0return EXIT_FAILURE;
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0}
As far as I can see, create_domain() mostly returns libxl error codes.
I think you should convert that one as well (in 0/-1, as it's internal,
and doing it in this patch would be ok).

The rest of the patch looks ok to me.

Thanks and Regards,
Dario
--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


--=-y/qK2h4CqUeW9APFIkdZ
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEABECAAYFAlbXIusACgkQk4XaBE3IOsQmhACgj7eqqmJbFFyR6fq9SewAFFxu
8osAnAmXWpQaFOFban79CAclqeXxOHm7
=1zvl
-----END PGP SIGNATURE-----

--=-y/qK2h4CqUeW9APFIkdZ--


--===============4299096529413697033==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs
IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y
Zy94ZW4tZGV2ZWwK

--===============4299096529413697033==--