From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH 0/9] xl: convert exit codes related to
 domain subcommands to EXIT_[SUCCESS|FAILURE]
Date: Wed, 2 Mar 2016 19:05:05 +0100
Message-ID: <1456941905.2959.399.camel@citrix.com>
References: <1456318407-3635-1-git-send-email-write.harmandeep@gmail.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0420114811856010511=="
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
 by lists.xen.org with esmtp (Exim 4.84)
 (envelope-from <prvs=8628d4685=dario.faggioli@citrix.com>)
 id 1abB9g-0001k5-Bt
 for xen-devel@lists.xenproject.org; Wed, 02 Mar 2016 18:05:48 +0000
In-Reply-To: <1456318407-3635-1-git-send-email-write.harmandeep@gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xen.org
Sender: "Xen-devel" <xen-devel-bounces@lists.xen.org>
To: Harmandeep Kaur <write.harmandeep@gmail.com>, xen-devel@lists.xenproject.org
Cc: wei.liu2@citrix.com, ian.jackson@eu.citrix.com, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com
List-Id: xen-devel@lists.xenproject.org

--===============0420114811856010511==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-Jx/486FXlAIVPBZ4FiXL"

--=-Jx/486FXlAIVPBZ4FiXL
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, 2016-02-24 at 18:23 +0530, Harmandeep Kaur wrote:
> *main_foo() is treated somewhat as a regular main(), it is changed to
> return EXIT_SUCCESS or EXIT_FAILURE.
>=20
Ok, I think I've looked at all the patches now. Good work. :-)

There were a few issues and mistakes, but mostly I think the various
functions could have been grouped better in the various patches.

I tried to point that out when I thought it was the case, and to
provide suggestions... let me know if there is something you did not
understand or need clarifications.

Looking forward to v2. :-)

Thanks and Regards,
Dario
--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


--=-Jx/486FXlAIVPBZ4FiXL
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEABECAAYFAlbXK1IACgkQk4XaBE3IOsRLlgCfQD7/bKKXuc1b+iCvIbX3U2z4
CAAAn0jdQSVU62d80XENXDbBBnzCofWZ
=hmwH
-----END PGP SIGNATURE-----

--=-Jx/486FXlAIVPBZ4FiXL--


--===============0420114811856010511==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs
IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y
Zy94ZW4tZGV2ZWwK

--===============0420114811856010511==--