From mboxrd@z Thu Jan 1 00:00:00 1970 From: Harmandeep Kaur Subject: [PATCH v5] libxl: handle failure of xc_version() in libxl_get_version_info() Date: Thu, 3 Mar 2016 01:39:24 +0530 Message-ID: <1456949364-2527-1-git-send-email-write.harmandeep@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.84) (envelope-from ) id 1abD5b-0002zk-5r for xen-devel@lists.xenproject.org; Wed, 02 Mar 2016 20:09:43 +0000 Received: by mail-pf0-f196.google.com with SMTP id 184so1990pff.1 for ; Wed, 02 Mar 2016 12:09:41 -0800 (PST) List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: xen-devel@lists.xenproject.org Cc: wei.liu2@citrix.com, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, dario.faggioli@citrix.com, ian.jackson@eu.citrix.com, Harmandeep Kaur List-Id: xen-devel@lists.xenproject.org Q2hlY2sgdGhlIHJldHVybiB2YWx1ZSBvZiB4Y192ZXJzaW9uKCkgYW5kIHJldHVybiBOVUxMIGlm IGl0CmZhaWxzLiBsaWJ4bF9nZXRfdmVyc2lvbl9pbmZvKCkgY2FuIGFsc28gcmV0dXJuIE5VTEwg bm93LgoKR3JvdXAgYWxsIGNhbGxzIHRvIHhjX3ZlcnNpb24oKSAsIHNvIHRoYXQgZGF0YSBjb3Bp ZXMgaW4KdmFyaW91cyBpbmZvIGZpZWxkcyBvbmx5IGlmIGFsbCBjYWxscyB0byB4Y192ZXJzaW9u IHdvcmsuClRoaXMgd2lsbCBlbGltaW5hdGUgY2FzZXMgaW4gd2hpY2ggb25seSBwYXJ0aWFsIGlu Zm9ybWF0aW9uCmlzIHVwZGF0ZWQuCgpDYWxsZXJzIG9mIHRoZSBmdW5jdGlvbiBsaWJ4bF9nZXRf dmVyc2lvbl9pbmZvKCkgYXJlIGFscmVhZHkKcHJlcGFyZWQgdG8gZGVhbCB3aXRoIGEgTlVMTCBy ZXR1cm4gdmFsdWUuCgpDb3Zlcml0eSBJRCAxMzUxMjE3CgpTaWduZWQtb2ZmLWJ5OiBIYXJtYW5k ZWVwIEthdXIgPHdyaXRlLmhhcm1hbmRlZXBAZ21haWwuY29tPgpSZXZpZXdlZC1ieTogRGFyaW8g RmFnZ2lvbGkgPGRhcmlvLmZhZ2dpb2xpQGNpdHJpeC5jb20+Ci0tLQp2MjogQ2hhbmdlIGxvY2Fs IHZhcmlhYmxlIHJjIHRvIHIuIFJlbW92ZXMgeGVuX3ZlcnNpb24uCiAgICBCZXR0ZXIgcmVhZGli bGl0eSBvZiBibG9ja3Mgb2YgY29kZS4gR3JvdXAgYWxsIGNhbGxzIHRvCiAgICB4Y192ZXJzaW9u KCkgLCBzbyB0aGF0IGRhdGEgY29waWVzIGluIHZhcmlvdXMgaW5mbwogICAgZmllbGRzIG9ubHkg aWYgYWxsIGNhbGxzIHRvIHhjX3ZlcnNpb24gZ28gZXJyb3ItZnJlZS4KCnYzOiBHcm91cCBhbGwg Y2FsbHMgdG8geGNfdmVyc2lvbigpICwgc28gdGhhdCBkYXRhIGNvcGllcyBpbgogICAgdmFyaW91 cyBpbmZvIGZpZWxkcyBvbmx5IGlmIGFsbCBjYWxscyB0byB4Y192ZXJzaW9uIHdvcmsuCgp2NDog SW1wcm92ZSBzdWJvcHRpbWFsIHN1YmplY3QuIFJlYWRkcyB4ZW5fdmVyc2lvbiB0byBzdWl0CiAg ICByZS1hcnJhbmdlbWVudC4KCnY1OiBDaGFuZ2UgZGF0YXR5cGUgb2YgJ3InIGZyb20gbG9uZyB0 byBpbnQuCi0tLQogdG9vbHMvbGlieGwvbGlieGwuYyB8IDMzICsrKysrKysrKysrKysrKysrKy0t LS0tLS0tLS0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDE4IGluc2VydGlvbnMoKyksIDE1IGRlbGV0 aW9ucygtKQoKZGlmZiAtLWdpdCBhL3Rvb2xzL2xpYnhsL2xpYnhsLmMgYi90b29scy9saWJ4bC9s aWJ4bC5jCmluZGV4IDRjZGMxNjkuLmQ3YmM4MzYgMTAwNjQ0Ci0tLSBhL3Rvb2xzL2xpYnhsL2xp YnhsLmMKKysrIGIvdG9vbHMvbGlieGwvbGlieGwuYwpAQCAtNTIwMyw0MSArNTIwMyw0NCBAQCBj b25zdCBsaWJ4bF92ZXJzaW9uX2luZm8qIGxpYnhsX2dldF92ZXJzaW9uX2luZm8obGlieGxfY3R4 ICpjdHgpCiAgICAgICAgIHhlbl9jb21tYW5kbGluZV90IHhlbl9jb21tYW5kbGluZTsKICAgICB9 IHU7CiAgICAgbG9uZyB4ZW5fdmVyc2lvbjsKKyAgICBpbnQgciA9IDA7CiAgICAgbGlieGxfdmVy c2lvbl9pbmZvICppbmZvID0gJmN0eC0+dmVyc2lvbl9pbmZvOwogCiAgICAgaWYgKGluZm8tPnhl bl92ZXJzaW9uX2V4dHJhICE9IE5VTEwpCiAgICAgICAgIGdvdG8gb3V0OwogCiAgICAgeGVuX3Zl cnNpb24gPSB4Y192ZXJzaW9uKGN0eC0+eGNoLCBYRU5WRVJfdmVyc2lvbiwgTlVMTCk7CisgICAg aWYgKHhlbl92ZXJzaW9uIDwgMCkgZ290byBvdXQ7CisgICAgciA9IHhjX3ZlcnNpb24oY3R4LT54 Y2gsIFhFTlZFUl9leHRyYXZlcnNpb24sICZ1Lnhlbl9leHRyYSk7CisgICAgaWYgKHIgPCAwKSBn b3RvIG91dDsKKyAgICByID0geGNfdmVyc2lvbihjdHgtPnhjaCwgWEVOVkVSX2NvbXBpbGVfaW5m bywgJnUueGVuX2NjKTsKKyAgICBpZiAociA8IDApIGdvdG8gb3V0OworICAgIHIgPSB4Y192ZXJz aW9uKGN0eC0+eGNoLCBYRU5WRVJfY2FwYWJpbGl0aWVzLCAmdS54ZW5fY2Fwcyk7CisgICAgaWYg KHIgPCAwKSBnb3RvIG91dDsKKyAgICByID0geGNfdmVyc2lvbihjdHgtPnhjaCwgWEVOVkVSX2No YW5nZXNldCwgJnUueGVuX2NoZ3NldCk7CisgICAgaWYgKHIgPCAwKSBnb3RvIG91dDsKKyAgICBy ID0geGNfdmVyc2lvbihjdHgtPnhjaCwgWEVOVkVSX3BsYXRmb3JtX3BhcmFtZXRlcnMsICZ1LnBf cGFybXMpOworICAgIGlmIChyIDwgMCkgZ290byBvdXQ7CisgICAgciA9IGluZm8tPnBhZ2VzaXpl ID0geGNfdmVyc2lvbihjdHgtPnhjaCwgWEVOVkVSX3BhZ2VzaXplLCBOVUxMKTsKKyAgICBpZiAo ciA8IDApIGdvdG8gb3V0OworICAgIHIgPSB4Y192ZXJzaW9uKGN0eC0+eGNoLCBYRU5WRVJfY29t bWFuZGxpbmUsICZ1Lnhlbl9jb21tYW5kbGluZSk7CisgICAgaWYgKHIgPCAwKSBnb3RvIG91dDsK KwogICAgIGluZm8tPnhlbl92ZXJzaW9uX21ham9yID0geGVuX3ZlcnNpb24gPj4gMTY7CiAgICAg aW5mby0+eGVuX3ZlcnNpb25fbWlub3IgPSB4ZW5fdmVyc2lvbiAmIDB4RkY7Ci0KLSAgICB4Y192 ZXJzaW9uKGN0eC0+eGNoLCBYRU5WRVJfZXh0cmF2ZXJzaW9uLCAmdS54ZW5fZXh0cmEpOwogICAg IGluZm8tPnhlbl92ZXJzaW9uX2V4dHJhID0gbGlieGxfX3N0cmR1cChOT0dDLCB1Lnhlbl9leHRy YSk7Ci0KLSAgICB4Y192ZXJzaW9uKGN0eC0+eGNoLCBYRU5WRVJfY29tcGlsZV9pbmZvLCAmdS54 ZW5fY2MpOwogICAgIGluZm8tPmNvbXBpbGVyID0gbGlieGxfX3N0cmR1cChOT0dDLCB1Lnhlbl9j Yy5jb21waWxlcik7CiAgICAgaW5mby0+Y29tcGlsZV9ieSA9IGxpYnhsX19zdHJkdXAoTk9HQywg dS54ZW5fY2MuY29tcGlsZV9ieSk7CiAgICAgaW5mby0+Y29tcGlsZV9kb21haW4gPSBsaWJ4bF9f c3RyZHVwKE5PR0MsIHUueGVuX2NjLmNvbXBpbGVfZG9tYWluKTsKICAgICBpbmZvLT5jb21waWxl X2RhdGUgPSBsaWJ4bF9fc3RyZHVwKE5PR0MsIHUueGVuX2NjLmNvbXBpbGVfZGF0ZSk7Ci0KLSAg ICB4Y192ZXJzaW9uKGN0eC0+eGNoLCBYRU5WRVJfY2FwYWJpbGl0aWVzLCAmdS54ZW5fY2Fwcyk7 CiAgICAgaW5mby0+Y2FwYWJpbGl0aWVzID0gbGlieGxfX3N0cmR1cChOT0dDLCB1Lnhlbl9jYXBz KTsKLQotICAgIHhjX3ZlcnNpb24oY3R4LT54Y2gsIFhFTlZFUl9jaGFuZ2VzZXQsICZ1Lnhlbl9j aGdzZXQpOwogICAgIGluZm8tPmNoYW5nZXNldCA9IGxpYnhsX19zdHJkdXAoTk9HQywgdS54ZW5f Y2hnc2V0KTsKLQotICAgIHhjX3ZlcnNpb24oY3R4LT54Y2gsIFhFTlZFUl9wbGF0Zm9ybV9wYXJh bWV0ZXJzLCAmdS5wX3Bhcm1zKTsKICAgICBpbmZvLT52aXJ0X3N0YXJ0ID0gdS5wX3Bhcm1zLnZp cnRfc3RhcnQ7Ci0KLSAgICBpbmZvLT5wYWdlc2l6ZSA9IHhjX3ZlcnNpb24oY3R4LT54Y2gsIFhF TlZFUl9wYWdlc2l6ZSwgTlVMTCk7Ci0KLSAgICB4Y192ZXJzaW9uKGN0eC0+eGNoLCBYRU5WRVJf Y29tbWFuZGxpbmUsICZ1Lnhlbl9jb21tYW5kbGluZSk7CiAgICAgaW5mby0+Y29tbWFuZGxpbmUg PSBsaWJ4bF9fc3RyZHVwKE5PR0MsIHUueGVuX2NvbW1hbmRsaW5lKTsKIAogIG91dDoKICAgICBH Q19GUkVFOwotICAgIHJldHVybiBpbmZvOworICAgIHJldHVybiByIDwgMCA/IE5VTEwgOiBpbmZv OwogfQogCiBsaWJ4bF92Y3B1aW5mbyAqbGlieGxfbGlzdF92Y3B1KGxpYnhsX2N0eCAqY3R4LCB1 aW50MzJfdCBkb21pZCwKLS0gCjIuNS4wCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMu eGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9yZy94ZW4tZGV2ZWwK