From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v2 3/3] xl: new "loglvl" command Date: Mon, 7 Mar 2016 19:07:19 +0100 Message-ID: <1457374039.3102.82.camel@citrix.com> References: <56D9C80702000078000D9910@prv-mh.provo.novell.com> <56D9CA6002000078000D9935@prv-mh.provo.novell.com> <1457117113.2959.594.camel@citrix.com> <56DD783602000078000D9EE0@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8677342341240557394==" Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.84) (envelope-from ) id 1aczZ6-0000dl-LZ for xen-devel@lists.xenproject.org; Mon, 07 Mar 2016 18:07:32 +0000 In-Reply-To: <56DD783602000078000D9EE0@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Jan Beulich Cc: Ian Jackson , Wei Liu , xen-devel , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org --===============8677342341240557394== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-4kvexRRohwALS5DrNGPe" --=-4kvexRRohwALS5DrNGPe Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2016-03-07 at 04:46 -0700, Jan Beulich wrote: > > > > On 04.03.16 at 19:45, wrote: > > On Fri, 2016-03-04 at 09:48 -0700, Jan Beulich wrote: > > > --- a/tools/libxl/libxl.c > > > +++ b/tools/libxl/libxl.c > > > @@ -5958,6 +5958,26 @@ int libxl_send_debug_keys(libxl_ctx *ctx > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0return 0; > > > =C2=A0} > > > =C2=A0 > > > +int libxl_log_level(libxl_ctx *ctx, bool set, bool guest, > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0int *lower_thresh, in= t *upper_thresh) > > > +{ > > > +=C2=A0=C2=A0=C2=A0=C2=A0int ret; > > >=20 > > As per libxl coding style, this wants to be 'r'. > This and everything else below look to be valid comments, but > it's rather frustrating that simply cloning an existing function (I > user the debug key ones as basis) doesn't give me valid code, > the more that I did scroll up and down a few pages to see > whether I just happened to pick a particularly bad example. > Hehe, but do you understand that, saying this, you're making it very likely that people will ask *you* to fix=C2=A0libxl_send_debug_keys() --and perhaps more tool side code? :-P :-P No, jokes apart, I agree that inconsistency is a real bad thing... but it's an hard fight, and we do have examples spread all around the source code (both Xen and tools), AFAICT. I run into the patch, decided to have a look, and thought I better say what I found, with the aim of fighting exactly that (inconsistency in the code). If there is anything else I can do for help, feel free to ask (e.g., I guess I can send a patch to fix style of libxl_send_debug_keys() myself :-)). Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-4kvexRRohwALS5DrNGPe Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEABECAAYFAlbdw1cACgkQk4XaBE3IOsSxMACfURGPCsSWVW+VZiSolSPwRyPc k9oAn3Mz0xCwy/yQ/DrSb2JUcEryMaZj =LkLU -----END PGP SIGNATURE----- --=-4kvexRRohwALS5DrNGPe-- --===============8677342341240557394== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y Zy94ZW4tZGV2ZWwK --===============8677342341240557394==--