From: Dario Faggioli <dario.faggioli@citrix.com>
To: Quan Xu <quan.xu@intel.com>, xen-devel@lists.xen.org
Cc: Jan Beulich <jbeulich@suse.com>,
Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
Subject: Re: [PATCH 1/2] IOMMU/spinlock: Fix a bug found in AMD IOMMU initialization.
Date: Tue, 8 Mar 2016 13:12:39 +0100 [thread overview]
Message-ID: <1457439159.3102.181.camel@citrix.com> (raw)
In-Reply-To: <1457435357-34073-2-git-send-email-quan.xu@intel.com>
[-- Attachment #1.1: Type: text/plain, Size: 1319 bytes --]
On Tue, 2016-03-08 at 19:09 +0800, Quan Xu wrote:
> Doing what we do serves as a fix for a bug found in AMD IOMMU
> initialization.
>
This first line is rather useless, if not worse. :-)
I don't know (provided a new version is not necessary, and provided
maintainers agree with me :-)) whether you need to repost or it can be
removed when code is committed.
> Signed-off-by: Quan Xu <quan.xu@intel.com>
> CC: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
> CC: Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>
>
get_maintainer.pl gives me only Suravee, as Aravind stepped down a few
days ago, so he shouldn't be bothered (and, in fact, I'm moving him
from Cc to Bcc).
> CC: Dario Faggioli <dario.faggioli@citrix.com>
> CC: Jan Beulich <jbeulich@suse.com>
>
(BTW, it's of course fine to include me and Jan, despite what
get_maintainer.pl's output, as we've been involved in previous rounds
of review.)
All that being said:
Reviewed-by: Dario Faggioli <dario.faggioli@citrix.com>
Thanks and Regards,
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-03-08 12:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-08 11:09 [PATCH 0/2] Make the pcidevs_lock a recursive one Quan Xu
2016-03-08 11:09 ` [PATCH 1/2] IOMMU/spinlock: Fix a bug found in AMD IOMMU initialization Quan Xu
2016-03-08 12:12 ` Dario Faggioli [this message]
2016-03-08 12:35 ` Xu, Quan
2016-03-08 13:54 ` Jan Beulich
2016-03-08 11:09 ` [PATCH 2/2] IOMMU/spinlock: Make the pcidevs_lock a recursive one Quan Xu
2016-03-08 12:29 ` Dario Faggioli
2016-03-08 12:39 ` Xu, Quan
2016-03-08 13:48 ` Jan Beulich
2016-03-08 13:58 ` Xu, Quan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1457439159.3102.181.camel@citrix.com \
--to=dario.faggioli@citrix.com \
--cc=jbeulich@suse.com \
--cc=quan.xu@intel.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).