From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH 4/9] xl: Improve return and exit codes of main_console(), main_vncviewer() and main_dump_core(). Date: Tue, 8 Mar 2016 15:16:23 +0100 Message-ID: <1457446583.3102.232.camel@citrix.com> References: <1456318407-3635-1-git-send-email-write.harmandeep@gmail.com> <1456318407-3635-5-git-send-email-write.harmandeep@gmail.com> <1456399985.6288.99.camel@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1282615573872363675==" Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.84) (envelope-from ) id 1adIR4-0001o8-AG for xen-devel@lists.xenproject.org; Tue, 08 Mar 2016 14:16:30 +0000 In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Harmandeep Kaur Cc: xen-devel List-Id: xen-devel@lists.xenproject.org --===============1282615573872363675== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-FhvFqF0MgEk0e9OdwHl0" --=-FhvFqF0MgEk0e9OdwHl0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable [Re-adding xen-devel... please, don't drop it. :-)] On Tue, 2016-03-08 at 13:08 +0530, Harmandeep Kaur wrote: > On Thu, Feb 25, 2016 at 5:03 PM, Dario Faggioli > wrote: > >=20 >=20 > > > diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c > > >=20 > > > @@ -3457,8 +3457,8 @@ int main_vncviewer(int argc, char **argv) > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0domid =3D find_domain(argv[optind]); > > >=20 > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0if (vncviewer(domid, autopass)) > > > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0return 1; > > > -=C2=A0=C2=A0=C2=A0=C2=A0return 0; > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0return EXIT_FAILURE; > > > +=C2=A0=C2=A0=C2=A0=C2=A0return EXIT_SUCCESS; > > >=20 > > Have a look at vncviewer() and autoconnect_vncviewer() too. > >=20 > I am not sure about vncviewer(), do we need something like below: >=20 > static int vncviewer(uint32_t domid, int autopass) > { > =C2=A0=C2=A0=C2=A0=C2=A0if (!libxl_vncviewer_exec(ctx, domid, autopass)) = { > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0fprintf(stderr, "Unable t= o execute vncviewer\n"); > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0return 1; > =C2=A0=C2=A0=C2=A0=C2=A0} > } >=20 That won't compile, I think. It's an internal function, and this patch is changing a bunch of internal functions into returning -1 on failure ad 0 on success, which is something vncviewer() is not doing. It's not too big of a deal, honestly, and you can even let it alone (we're not going to get 100% consistency anyway), but I thought you may want to at least consider what to do. OTOH, autoconnect_vncviewer() does have an _exit() that needs to be dealt with. Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-FhvFqF0MgEk0e9OdwHl0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEABECAAYFAlbe3rcACgkQk4XaBE3IOsSk2QCfeLkE0e/EhfdeddLRCvlol96e looAn3thrKNuEnYDJnVBL0dRJqb636Yx =sUWh -----END PGP SIGNATURE----- --=-FhvFqF0MgEk0e9OdwHl0-- --===============1282615573872363675== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y Zy94ZW4tZGV2ZWwK --===============1282615573872363675==--