From mboxrd@z Thu Jan 1 00:00:00 1970 From: Harmandeep Kaur Subject: [PATCH 2/9 v2] xl: Improve return and exit codes of restore and save related functions. Date: Wed, 9 Mar 2016 00:32:03 +0530 Message-ID: <1457463730-4712-3-git-send-email-write.harmandeep@gmail.com> References: <1457463730-4712-1-git-send-email-write.harmandeep@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.84) (envelope-from ) id 1adMu1-0000mS-Fx for xen-devel@lists.xenproject.org; Tue, 08 Mar 2016 19:02:41 +0000 Received: by mail-wm0-f66.google.com with SMTP id p65so5915506wmp.1 for ; Tue, 08 Mar 2016 11:02:40 -0800 (PST) In-Reply-To: <1457463730-4712-1-git-send-email-write.harmandeep@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: xen-devel@lists.xenproject.org Cc: wei.liu2@citrix.com, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, dario.faggioli@citrix.com, ian.jackson@eu.citrix.com, Harmandeep Kaur List-Id: xen-devel@lists.xenproject.org c2F2ZV9kb21haW4oKSwgbWFpbl9yZXN0b3JlKCksIG1haW5fc2F2ZSgpIGFuZCBtYWluX3JlbXVz KCkgaW4gdGhlIGZpbGUKeGxfY21kaW1wbCBhcmUgZml4ZWQuCgpTaWduZWQtb2ZmLWJ5OiBIYXJt YW5kZWVwIEthdXIgPHdyaXRlLmhhcm1hbmRlZXBAZ21haWwuY29tPgotLS0KdjI6IEFkZCBtYWlu X3JlbXVzKCkuCiAgICBSZW1vdmUgY3JlYXRlX2RvbWFpbigpLgotLS0KIHRvb2xzL2xpYnhsL3hs X2NtZGltcGwuYyB8IDIyICsrKysrKysrKysrLS0tLS0tLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAx MSBpbnNlcnRpb25zKCspLCAxMSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS90b29scy9saWJ4 bC94bF9jbWRpbXBsLmMgYi90b29scy9saWJ4bC94bF9jbWRpbXBsLmMKaW5kZXggMDg4OTcxZS4u NjkwZWI5MSAxMDA2NDQKLS0tIGEvdG9vbHMvbGlieGwveGxfY21kaW1wbC5jCisrKyBiL3Rvb2xz L2xpYnhsL3hsX2NtZGltcGwuYwpAQCAtNDEzMSw3ICs0MTMxLDcgQEAgc3RhdGljIGludCBzYXZl X2RvbWFpbih1aW50MzJfdCBkb21pZCwgY29uc3QgY2hhciAqZmlsZW5hbWUsIGludCBjaGVja3Bv aW50LAogICAgIGZkID0gb3BlbihmaWxlbmFtZSwgT19XUk9OTFl8T19DUkVBVHxPX1RSVU5DLCAw NjQ0KTsKICAgICBpZiAoZmQgPCAwKSB7CiAgICAgICAgIGZwcmludGYoc3RkZXJyLCAiRmFpbGVk IHRvIG9wZW4gdGVtcCBmaWxlICVzIGZvciB3cml0aW5nXG4iLCBmaWxlbmFtZSk7Ci0gICAgICAg IGV4aXQoMik7CisgICAgICAgIGV4aXQoRVhJVF9GQUlMVVJFKTsKICAgICB9CiAKICAgICBzYXZl X2RvbWFpbl9jb3JlX3dyaXRlY29uZmlnKGZkLCBmaWxlbmFtZSwgY29uZmlnX2RhdGEsIGNvbmZp Z19sZW4pOwpAQCAtNDE1MSw3ICs0MTUxLDcgQEAgc3RhdGljIGludCBzYXZlX2RvbWFpbih1aW50 MzJfdCBkb21pZCwgY29uc3QgY2hhciAqZmlsZW5hbWUsIGludCBjaGVja3BvaW50LAogICAgIGVs c2UKICAgICAgICAgbGlieGxfZG9tYWluX2Rlc3Ryb3koY3R4LCBkb21pZCwgMCk7CiAKLSAgICBl eGl0KHJjIDwgMCA/IDEgOiAwKTsKKyAgICBleGl0KHJjIDwgMCA/IEVYSVRfRkFJTFVSRSA6IEVY SVRfU1VDQ0VTUyk7CiB9CiAKIHN0YXRpYyBwaWRfdCBjcmVhdGVfbWlncmF0aW9uX2NoaWxkKGNv bnN0IGNoYXIgKnJ1bmUsIGludCAqc2VuZF9mZCwKQEAgLTQ2MjUsNyArNDYyNSw3IEBAIGludCBt YWluX3Jlc3RvcmUoaW50IGFyZ2MsIGNoYXIgKiphcmd2KQogICAgICAgICBjaGVja3BvaW50X2Zp bGUgPSBhcmd2W29wdGluZCArIDFdOwogICAgIH0gZWxzZSB7CiAgICAgICAgIGhlbHAoInJlc3Rv cmUiKTsKLSAgICAgICAgcmV0dXJuIDI7CisgICAgICAgIHJldHVybiBFWElUX0ZBSUxVUkU7CiAg ICAgfQogCiAgICAgbWVtc2V0KCZkb21faW5mbywgMCwgc2l6ZW9mKGRvbV9pbmZvKSk7CkBAIC00 NjQyLDkgKzQ2NDIsOSBAQCBpbnQgbWFpbl9yZXN0b3JlKGludCBhcmdjLCBjaGFyICoqYXJndikK IAogICAgIHJjID0gY3JlYXRlX2RvbWFpbigmZG9tX2luZm8pOwogICAgIGlmIChyYyA8IDApCi0g ICAgICAgIHJldHVybiAtcmM7CisgICAgICAgIHJldHVybiBFWElUX0ZBSUxVUkU7CiAKLSAgICBy ZXR1cm4gMDsKKyAgICByZXR1cm4gRVhJVF9TVUNDRVNTOwogfQogCiBpbnQgbWFpbl9taWdyYXRl X3JlY2VpdmUoaW50IGFyZ2MsIGNoYXIgKiphcmd2KQpAQCAtNDcwMCw3ICs0NzAwLDcgQEAgaW50 IG1haW5fc2F2ZShpbnQgYXJnYywgY2hhciAqKmFyZ3YpCiAKICAgICBpZiAoYXJnYy1vcHRpbmQg PiAzKSB7CiAgICAgICAgIGhlbHAoInNhdmUiKTsKLSAgICAgICAgcmV0dXJuIDI7CisgICAgICAg IHJldHVybiBFWElUX0ZBSUxVUkU7CiAgICAgfQogCiAgICAgZG9taWQgPSBmaW5kX2RvbWFpbihh cmd2W29wdGluZF0pOwpAQCAtNDcwOSw3ICs0NzA5LDcgQEAgaW50IG1haW5fc2F2ZShpbnQgYXJn YywgY2hhciAqKmFyZ3YpCiAgICAgICAgIGNvbmZpZ19maWxlbmFtZSA9IGFyZ3Zbb3B0aW5kICsg Ml07CiAKICAgICBzYXZlX2RvbWFpbihkb21pZCwgZmlsZW5hbWUsIGNoZWNrcG9pbnQsIGxlYXZl cGF1c2VkLCBjb25maWdfZmlsZW5hbWUpOwotICAgIHJldHVybiAwOworICAgIHJldHVybiBFWElU X1NVQ0NFU1M7CiB9CiAKIGludCBtYWluX21pZ3JhdGUoaW50IGFyZ2MsIGNoYXIgKiphcmd2KQpA QCAtODA4NSw3ICs4MDg1LDcgQEAgaW50IG1haW5fcmVtdXMoaW50IGFyZ2MsIGNoYXIgKiphcmd2 KQogICAgICAgICBzZW5kX2ZkID0gb3BlbigiL2Rldi9udWxsIiwgT19SRFdSLCAwNjQ0KTsKICAg ICAgICAgaWYgKHNlbmRfZmQgPCAwKSB7CiAgICAgICAgICAgICBwZXJyb3IoImZhaWxlZCB0byBv cGVuIC9kZXYvbnVsbCIpOwotICAgICAgICAgICAgZXhpdCgtMSk7CisgICAgICAgICAgICBleGl0 KEVYSVRfRkFJTFVSRSk7CiAgICAgICAgIH0KICAgICB9IGVsc2UgewogCkBAIC04MTAyLDcgKzgx MDIsNyBAQCBpbnQgbWFpbl9yZW11cyhpbnQgYXJnYywgY2hhciAqKmFyZ3YpCiAgICAgICAgIGlm ICghY29uZmlnX2xlbikgewogICAgICAgICAgICAgZnByaW50ZihzdGRlcnIsICJObyBjb25maWcg ZmlsZSBzdG9yZWQgZm9yIHJ1bm5pbmcgZG9tYWluIGFuZCAiCiAgICAgICAgICAgICAgICAgICAg ICJub25lIHN1cHBsaWVkIC0gY2Fubm90IHN0YXJ0IHJlbXVzLlxuIik7Ci0gICAgICAgICAgICBl eGl0KDEpOworICAgICAgICAgICAgZXhpdChFWElUX0ZBSUxVUkUpOwogICAgICAgICB9CiAKICAg ICAgICAgY2hpbGQgPSBjcmVhdGVfbWlncmF0aW9uX2NoaWxkKHJ1bmUsICZzZW5kX2ZkLCAmcmVj dl9mZCk7CkBAIC04MTIzLDcgKzgxMjMsNyBAQCBpbnQgbWFpbl9yZW11cyhpbnQgYXJnYywgY2hh ciAqKmFyZ3YpCiAgICAgaWYgKGxpYnhsX2RvbWFpbl9pbmZvKGN0eCwgMCwgZG9taWQpKSB7CiAg ICAgICAgIGZwcmludGYoc3RkZXJyLCAiUmVtdXM6IFByaW1hcnkgZG9tYWluIGhhcyBiZWVuIGRl c3Ryb3llZC5cbiIpOwogICAgICAgICBjbG9zZShzZW5kX2ZkKTsKLSAgICAgICAgcmV0dXJuIDA7 CisgICAgICAgIHJldHVybiBFWElUX1NVQ0NFU1M7CiAgICAgfQogCiAgICAgLyogSWYgd2UgYXJl IGhlcmUsIGl0IG1lYW5zIHJlbXVzIHNldHVwL2RvbWFpbiBzdXNwZW5kL2JhY2t1cCBoYXMKQEAg LTgxMzgsNyArODEzOCw3IEBAIGludCBtYWluX3JlbXVzKGludCBhcmdjLCBjaGFyICoqYXJndikK ICAgICB9CiAKICAgICBjbG9zZShzZW5kX2ZkKTsKLSAgICByZXR1cm4gLUVSUk9SX0ZBSUw7Cisg ICAgcmV0dXJuIEVYSVRfRkFJTFVSRTsKIH0KICNlbmRpZgogCi0tIAoyLjUuMAoKCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5n IGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbi5vcmcKaHR0cDovL2xpc3RzLnhlbi5vcmcveGVuLWRl dmVsCg==