From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH v7 for Xen 4.7 2/4] libxc: enable per-VCPU
 parameter settings for RTDS scheduler
Date: Thu, 17 Mar 2016 03:28:57 +0100
Message-ID: <1458181737.3102.957.camel@citrix.com>
References: <1458146871-2813-1-git-send-email-lichong659@gmail.com>
 <1458146871-2813-3-git-send-email-lichong659@gmail.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2056136798347158994=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1458146871-2813-3-git-send-email-lichong659@gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xen.org
Sender: "Xen-devel" <xen-devel-bounces@lists.xen.org>
To: Chong Li <lichong659@gmail.com>, xen-devel@lists.xen.org
Cc: Chong Li <chong.li@wustl.edu>, wei.liu2@citrix.com, Sisu Xi <xisisu@gmail.com>, george.dunlap@eu.citrix.com, Meng Xu <mengxu@cis.upenn.edu>, dgolomb@seas.upenn.edu
List-Id: xen-devel@lists.xenproject.org

--===============2056136798347158994==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-yYLbmdTuO1R90rRJIImq"

--=-yYLbmdTuO1R90rRJIImq
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, 2016-03-16 at 11:47 -0500, Chong Li wrote:
> Add xc_sched_rtds_vcpu_get/set functions to interact with
> Xen to get/set a domain's per-VCPU parameters.
>=20
Patch is ok, IMO, with only two minor comments.

First, the subject is a bit long. I'd go for:
"libxc: enable per-VCPU parameters for RTDS"

Second, here...

> Signed-off-by: Chong Li <chong.li@wustl.edu>
> Signed-off-by: Meng Xu <mengxu@cis.upenn.edu>
> Signed-off-by: Sisu Xi <xisisu@gmail.com>

> --- a/tools/libxc/xc_rt.c
> +++ b/tools/libxc/xc_rt.c
> @@ -62,3 +62,71 @@ int xc_sched_rtds_domain_get(xc_interface *xch,
> =C2=A0
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0return rc;
> =C2=A0}
> +
> +int xc_sched_rtds_vcpu_set(xc_interface *xch,
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0uint32_t domid,
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0struct xen_domctl_schedparam_vcpu *vcpus,
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0uint32_t num_vcpus)
> +{
> +=C2=A0=C2=A0=C2=A0=C2=A0int rc =3D 0;
>
rc does not need to be initialized to 0 (and hence it shouldn't be).

Even with only this fixed (i.e., even if the subject stays as it is):

Reviewed-by: Dario Faggioli <dario.faggioli@citrix.com>

Thanks and Regards,
Dario
--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


--=-yYLbmdTuO1R90rRJIImq
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEABECAAYFAlbqFmkACgkQk4XaBE3IOsTpxwCfZ9jqIE0F3Ezvv1Xug8Nr9bE2
2k0An0Lhfv07N6B34IKX/N0xM8P1W3xu
=+und
-----END PGP SIGNATURE-----

--=-yYLbmdTuO1R90rRJIImq--


--===============2056136798347158994==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs
IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y
Zy94ZW4tZGV2ZWwK

--===============2056136798347158994==--