From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v7 for Xen 4.7 1/4] xen: enable per-VCPU parameter settings for RTDS scheduler Date: Fri, 18 Mar 2016 11:47:57 +0100 Message-ID: <1458298077.15374.96.camel@citrix.com> References: <1458146871-2813-1-git-send-email-lichong659@gmail.com> <1458146871-2813-2-git-send-email-lichong659@gmail.com> <1458209010.15374.20.camel@citrix.com> <56EBBEB902000078000DE315@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1548488220181381824==" Return-path: In-Reply-To: <56EBBEB902000078000DE315@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Chong Li Cc: Chong Li , Sisu Xi , George Dunlap , xen-devel , Meng Xu , Jan Beulich , Dagaen Golomb List-Id: xen-devel@lists.xenproject.org --===============1548488220181381824== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-sqse/BPfPfi9U8Hu1QTD" --=-sqse/BPfPfi9U8Hu1QTD Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2016-03-18 at 01:39 -0600, Jan Beulich wrote: > >=C2=A0 > > > > On 17.03.16 at 21:42, wrote: > > On Thu, Mar 17, 2016 at 5:03 AM, Dario Faggioli > > wrote: > > >=C2=A0 > > > I'd say that, in this specific case, is not a big deal which one > > > of the > > > two approaches you take (mentioning or separate patch), but the > > > having > > > a separate one is indeed almost always preferable (e.g., the fix > > > can be > > > backported). > > If I choose mentioning, do I move the comment to the changelog? Or > > do I keep > > it here and say it again in the changelog? > Just consider what would happen if everyone mentioned in > comments the bugs they fixed. I think the answer to you question > is obvious then... > Exactly! :-) And, please (Chong), let me restate this: "having a separate one is indeed almost always preferable (e.g., the fix can be backported)" Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-sqse/BPfPfi9U8Hu1QTD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEABECAAYFAlbr3N0ACgkQk4XaBE3IOsR0sQCeJS//0kOUd707wOOshrGO3Itq JDcAoIgZM2oLSmWPcaj4V0CslSaHICn2 =rYS6 -----END PGP SIGNATURE----- --=-sqse/BPfPfi9U8Hu1QTD-- --===============1548488220181381824== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y Zy94ZW4tZGV2ZWwK --===============1548488220181381824==--