From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH v8 for Xen 4.7 2/4] libxc: enable per-VCPU
 parameter for RTDS
Date: Tue, 29 Mar 2016 19:08:34 +0200
Message-ID: <1459271314.5082.64.camel@citrix.com>
References: <1458336385-2606-1-git-send-email-lichong659@gmail.com>
 <1458336385-2606-3-git-send-email-lichong659@gmail.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0169944578346136250=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1458336385-2606-3-git-send-email-lichong659@gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xen.org
Sender: "Xen-devel" <xen-devel-bounces@lists.xen.org>
To: Chong Li <lichong659@gmail.com>, xen-devel@lists.xen.org, Wei Liu <Wei.Liu2@citrix.com>
Cc: george.dunlap@eu.citrix.com, dgolomb@seas.upenn.edu, Chong Li <chong.li@wustl.edu>, Meng Xu <mengxu@cis.upenn.edu>, Sisu Xi <xisisu@gmail.com>
List-Id: xen-devel@lists.xenproject.org

--===============0169944578346136250==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-mdrJhb7i+HhU8oRjlMm2"

--=-mdrJhb7i+HhU8oRjlMm2
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, 2016-03-18 at 16:26 -0500, Chong Li wrote:
> Add xc_sched_rtds_vcpu_get/set functions to interact with
> Xen to get/set a domain's per-VCPU parameters.
>=20
> Signed-off-by: Chong Li <chong.li@wustl.edu>
> Signed-off-by: Meng Xu <mengxu@cis.upenn.edu>
> Signed-off-by: Sisu Xi <xisisu@gmail.com>
>=20
> ---
> Changes on PATCH v6:
> 1) Resolve some coding sytle issues
>=20
You did not mention any chage since v7, but it looks like you did the
changes I suggested.

That should have been mentioned, if only, to help people figuring out
that it's the only thing that actually changed.

Also, Wei said:

Acked-by: Wei Liu <wei.liu2@citrix.com>

And I said that, if you fixed the pointless initialization of rc, you
could add:

Reviewed-by: Dario Faggioli <dario.faggioli@citrix.com>

I think both still applies. Maybe it was ok to neglect Wei's Ack, since
you changed the subject line, which is important. But you should say
so, and catch his attention on this, so he can re-Ack the patch (if he
wants).

My tag, for sure, still applies, as I explicitly said so, and so you
should have put it in this version, to speedup review/commit.

In any case, I'm re-issueing it:

Reviewed-by: Dario Faggioli <dario.faggioli@citrix.com>

Please, stick it below the S-o-b tags in next version.

Thanks and Regards,
Dario
--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


--=-mdrJhb7i+HhU8oRjlMm2
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEABECAAYFAlb6tpIACgkQk4XaBE3IOsQSvgCgnT0bF2P9/+nvodVus76oJ2pA
SZIAn0H67lVybyiWLVympKNPcb9+MahN
=B1Jf
-----END PGP SIGNATURE-----

--=-mdrJhb7i+HhU8oRjlMm2--


--===============0169944578346136250==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs
IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y
Zy94ZW4tZGV2ZWwK

--===============0169944578346136250==--