From: Dario Faggioli <dario.faggioli@citrix.com>
To: Chong Li <lichong659@gmail.com>, xen-devel@lists.xen.org
Cc: Chong Li <chong.li@wustl.edu>,
wei.liu2@citrix.com, Sisu Xi <xisisu@gmail.com>,
george.dunlap@eu.citrix.com, ian.jackson@eu.citrix.com,
Meng Xu <mengxu@cis.upenn.edu>,
dgolomb@seas.upenn.edu
Subject: Re: [PATCH v9 for Xen 4.7 3/4] libxl: enable per-VCPU parameter for RTDS
Date: Fri, 1 Apr 2016 14:53:37 +0200 [thread overview]
Message-ID: <1459515217.5082.245.camel@citrix.com> (raw)
In-Reply-To: <1459486786-3085-4-git-send-email-lichong659@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1635 bytes --]
On Thu, 2016-03-31 at 23:59 -0500, Chong Li wrote:
> Add libxl_vcpu_sched_params_get/set and sched_rtds_vcpu_get/set
> functions to support per-VCPU settings.
>
> Signed-off-by: Chong Li <chong.li@wustl.edu>
> Signed-off-by: Meng Xu <mengxu@cis.upenn.edu>
> Signed-off-by: Sisu Xi <xisisu@gmail.com>
>
> Acked-by: Wei Liu <wei.liu2@citrix.com>
> Reviewed-by: Dario Faggioli <dario.faggioli@citrix.com>
>
You added a new function, so you probably should have dropped the tags.
Anyway, I'll re-issue mine:
Reviewed-by: Dario Faggioli <dario.faggioli@citrix.com>
There are still things I'd like being done better. There's a certain
amount of code duplication, and there still are two instances of this
pattern (the 'else' is superfluous):
> + if (scinfo->num_vcpus > 0) {
> + rc = ERROR_INVAL;
> + goto out;
> + } else {
> + num_vcpus = info.max_vcpu_id + 1;
> + GCNEW_ARRAY(vcpus, num_vcpus);
> + for (i = 0; i < num_vcpus; i++)
> + vcpus[i].vcpuid = i;
> + }
> +
But Wei said (a few series versions ago) he is kinda fine with this,
and I also don't think the series should be blocked because of it. We
can improve and refactor things at a later point (adding this to my
TODO list).
Thanks and Regards,
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-04-01 12:53 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-01 4:59 [PATCH v9 for Xen 4.7 0/4] Enable per-VCPU parameter for RTDS Chong Li
2016-04-01 4:59 ` [PATCH v9 for Xen 4.7 1/4] xen: enable " Chong Li
2016-04-01 9:35 ` Jan Beulich
2016-04-01 12:37 ` Dario Faggioli
2016-04-04 15:14 ` [hypervisor deadlock] " Andrew Cooper
2016-04-04 15:58 ` Chong Li
2016-04-04 16:05 ` George Dunlap
2016-04-04 16:32 ` Dario Faggioli
2016-04-04 16:47 ` Wei Liu
2016-04-04 17:22 ` Chong Li
2016-04-01 4:59 ` [PATCH v9 for Xen 4.7 2/4] libxc: " Chong Li
2016-04-01 4:59 ` [PATCH v9 for Xen 4.7 3/4] libxl: " Chong Li
2016-04-01 12:53 ` Dario Faggioli [this message]
2016-04-01 13:40 ` Wei Liu
2016-04-06 14:32 ` Ian Jackson
2016-04-06 14:55 ` Ian Jackson
2016-04-06 15:04 ` Wei Liu
2016-04-06 15:22 ` Ian Jackson
2016-04-06 15:38 ` Ian Jackson
2016-04-06 16:36 ` Dario Faggioli
2016-04-06 16:41 ` Chong Li
2016-04-06 18:54 ` Andrew Cooper
2016-04-06 19:20 ` Chong Li
2016-04-06 19:23 ` Andrew Cooper
2016-04-06 19:30 ` Wei Liu
2016-04-06 19:41 ` Chong Li
2016-04-06 19:49 ` Wei Liu
2016-04-06 20:01 ` Dario Faggioli
2016-04-01 4:59 ` [PATCH v9 for Xen 4.7 4/4] xl: " Chong Li
2016-04-01 13:15 ` Dario Faggioli
2016-04-01 13:43 ` Wei Liu
2016-04-01 13:51 ` Dario Faggioli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1459515217.5082.245.camel@citrix.com \
--to=dario.faggioli@citrix.com \
--cc=chong.li@wustl.edu \
--cc=dgolomb@seas.upenn.edu \
--cc=george.dunlap@eu.citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=lichong659@gmail.com \
--cc=mengxu@cis.upenn.edu \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
--cc=xisisu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).