From: Dario Faggioli <dario.faggioli@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
Chong Li <lichong659@gmail.com>,
xen-devel@lists.xen.org
Cc: Chong Li <chong.li@wustl.edu>,
wei.liu2@citrix.com, george.dunlap@eu.citrix.com,
ian.jackson@eu.citrix.com, mengxu@cis.upenn.edu,
dgolomb@seas.upenn.edu
Subject: Re: [PATCH v1] libxc: fix uninitialized variable when changing rtds scheduling parameters
Date: Wed, 6 Apr 2016 23:50:20 +0200 [thread overview]
Message-ID: <1459979420.3166.115.camel@citrix.com> (raw)
In-Reply-To: <57057326.4060500@citrix.com>
[-- Attachment #1.1: Type: text/plain, Size: 1025 bytes --]
On Wed, 2016-04-06 at 21:35 +0100, Andrew Cooper wrote:
> On 06/04/16 21:30, Chong Li wrote:
> >
> > Commit 046c2b503a89d21b41e4d555a9f75d02af00dbc6 introduces a build
> > failure: in some cases (e.g., num_vcpus <=0),
> > xc_sched_rtds_vcpu_get/set returns an uninitialized variable.
> >
> > Fix it.
> >
> > Signed-off-by: Chong Li <chong.li@wustl.edu>
> >
> > ---
> > CC: <dario.faggioli@citrix.com>
> > CC: <george.dunlap@eu.citrix.com>
> > CC: <dgolomb@seas.upenn.edu>
> > CC: <mengxu@cis.upenn.edu>
> > CC: <wei.liu2@citrix.com>
> > CC: <ian.jackson@eu.citrix.com>
> > CC: <lichong659@gmail.com>
> LGTM.
>
> Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
>
Reviewed-by: Dario Faggioli <dario.faggioli@citrix.com>
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-04-06 21:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-06 20:30 [PATCH v1] libxc: fix uninitialized variable when changing rtds scheduling parameters Chong Li
2016-04-06 20:35 ` Andrew Cooper
2016-04-06 21:50 ` Dario Faggioli [this message]
2016-04-07 10:36 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1459979420.3166.115.camel@citrix.com \
--to=dario.faggioli@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=chong.li@wustl.edu \
--cc=dgolomb@seas.upenn.edu \
--cc=george.dunlap@eu.citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=lichong659@gmail.com \
--cc=mengxu@cis.upenn.edu \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).