From: "Luis R. Rodriguez" <mcgrof@kernel.org>
To: bp@alien8.de, hpa@zytor.com, tglx@linutronix.de,
mingo@redhat.com, rusty@rustcorp.com.au
Cc: xen-devel@lists.xensource.com, matt@codeblueprint.co.uk,
andrew.cooper3@citrix.com, x86@kernel.org,
linux-kernel@vger.kernel.org, luto@amacapital.net, jlee@suse.com,
"Luis R. Rodriguez" <mcgrof@kernel.org>,
lguest@lists.ozlabs.org, glin@suse.com, david.vrabel@citrix.com,
boris.ostrovsky@oracle.com, andriy.shevchenko@linux.intel.com
Subject: [PATCH v4 10/14] x86/cpu/intel: remove not needed paravirt_enabled() for f00f work around
Date: Wed, 6 Apr 2016 17:06:30 -0700 [thread overview]
Message-ID: <1459987594-5434-11-git-send-email-mcgrof@kernel.org> (raw)
In-Reply-To: <1459987594-5434-1-git-send-email-mcgrof@kernel.org>
The X86_BUG_F00F work around is responsible for fixing up the error
generated on attempted F00F exploitation from an OOPS to a SIGILL.
There is no reason why this code should not be allowed to run on
PV guest on a F00F-affected CPU -- it would simply never trigger.
The pv_enabled() check was there only to avoid printing the f00f
workaround, so removing the check is purely a cosmetic change.
Suggested-by: Andy Lutomirski <luto@amacapital.net>
Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
---
arch/x86/kernel/cpu/intel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/cpu/intel.c b/arch/x86/kernel/cpu/intel.c
index f71a34944b56..66509285ffdd 100644
--- a/arch/x86/kernel/cpu/intel.c
+++ b/arch/x86/kernel/cpu/intel.c
@@ -233,7 +233,7 @@ static void intel_workarounds(struct cpuinfo_x86 *c)
* The Quark is also family 5, but does not have the same bug.
*/
clear_cpu_bug(c, X86_BUG_F00F);
- if (!paravirt_enabled() && c->x86 == 5 && c->x86_model < 9) {
+ if (c->x86 == 5 && c->x86_model < 9) {
static int f00f_workaround_enabled;
set_cpu_bug(c, X86_BUG_F00F);
--
2.7.2
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-04-07 0:06 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-07 0:06 [PATCH v4 00/14] x86: remove paravirt_enabled Luis R. Rodriguez
2016-04-07 0:06 ` [PATCH v4 01/14] x86/boot: enumerate documentation for the x86 hardware_subarch Luis R. Rodriguez
2016-04-07 11:25 ` Andy Shevchenko
2016-04-07 22:36 ` Luis R. Rodriguez
2016-04-07 0:06 ` [PATCH v4 02/14] x86/xen: use X86_SUBARCH_XEN for PV guest boots Luis R. Rodriguez
2016-04-07 9:41 ` [Xen-devel] " David Vrabel
2016-04-07 0:06 ` [PATCH v4 03/14] tools/lguest: make lguest launcher use X86_SUBARCH_LGUEST explicitly Luis R. Rodriguez
2016-04-07 0:06 ` [PATCH v4 04/14] x86/rtc: replace paravirt rtc check with platform legacy quirk Luis R. Rodriguez
2016-04-07 9:42 ` [Xen-devel] " David Vrabel
2016-04-13 23:08 ` Luis R. Rodriguez
2016-04-07 12:55 ` Boris Ostrovsky
2016-04-08 0:32 ` Luis R. Rodriguez
2016-04-08 5:18 ` Juergen Gross
2016-04-08 6:29 ` Luis R. Rodriguez
2016-04-08 6:38 ` Juergen Gross
2016-04-08 6:56 ` Luis R. Rodriguez
2016-04-08 7:13 ` Juergen Gross
2016-04-08 7:36 ` Luis R. Rodriguez
2016-04-08 7:59 ` Juergen Gross
2016-04-08 12:37 ` Boris Ostrovsky
2016-04-08 18:45 ` Luis R. Rodriguez
2016-04-08 12:25 ` Boris Ostrovsky
2016-04-07 0:06 ` [PATCH v4 05/14] x86, ACPI: move ACPI_FADT_NO_CMOS_RTC check to ACPI boot code Luis R. Rodriguez
2016-04-07 0:06 ` [PATCH v4 06/14] x86/init: use a platform legacy quirk for ebda Luis R. Rodriguez
2016-04-07 9:44 ` [Xen-devel] " David Vrabel
2016-04-07 21:07 ` Luis R. Rodriguez
2016-04-07 0:06 ` [PATCH v4 07/14] tools/lguest: force disable tboot and apm Luis R. Rodriguez
2016-04-11 3:32 ` Rusty Russell
2016-04-07 0:06 ` [PATCH v4 08/14] apm32: remove paravirt_enabled() use Luis R. Rodriguez
2016-04-07 13:08 ` Boris Ostrovsky
2016-04-07 22:31 ` Luis R. Rodriguez
2016-04-07 0:06 ` [PATCH v4 09/14] x86/tboot: remove paravirt_enabled() Luis R. Rodriguez
2016-04-07 0:06 ` Luis R. Rodriguez [this message]
2016-04-07 0:06 ` [PATCH v4 11/14] pnpbios: replace paravirt_enabled() check with legacy device check Luis R. Rodriguez
[not found] ` <1459987594-5434-12-git-send-email-mcgrof-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2016-04-07 9:46 ` [Xen-devel] " David Vrabel
2016-04-07 21:42 ` Luis R. Rodriguez
2016-04-07 0:06 ` [PATCH v4 12/14] x86, ACPI: parse ACPI_FADT_LEGACY_DEVICES Luis R. Rodriguez
2016-04-07 0:06 ` [PATCH v4 13/14] x86/init: rename ebda code file Luis R. Rodriguez
2016-04-07 0:06 ` [PATCH v4 14/14] x86/paravirt: remove paravirt_enabled() Luis R. Rodriguez
2016-04-07 13:24 ` [Xen-devel] [PATCH v4 00/14] x86: remove paravirt_enabled Juergen Gross
2016-04-07 21:31 ` [PATCH v4 13/14] x86/init: rename ebda code file Luis R. Rodriguez
2016-04-08 1:14 ` [PATCH v4 00/14] x86: remove paravirt_enabled Luis R. Rodriguez
2016-04-08 10:23 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1459987594-5434-11-git-send-email-mcgrof@kernel.org \
--to=mcgrof@kernel.org \
--cc=andrew.cooper3@citrix.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=david.vrabel@citrix.com \
--cc=glin@suse.com \
--cc=hpa@zytor.com \
--cc=jlee@suse.com \
--cc=lguest@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=matt@codeblueprint.co.uk \
--cc=mingo@redhat.com \
--cc=rusty@rustcorp.com.au \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).