From: Julien Grall <julien.grall@arm.com>
To: xen-devel@lists.xen.org
Cc: Julien Grall <julien.grall@arm.com>,
sstabellini@kernel.org, shannon.zhao@linaro.org
Subject: [for-4.7 3/5] xen/arm: acpi: Fix SMP support when booting with ACPI
Date: Thu, 7 Apr 2016 11:59:54 +0100 [thread overview]
Message-ID: <1460026796-10899-4-git-send-email-julien.grall@arm.com> (raw)
In-Reply-To: <1460026796-10899-1-git-send-email-julien.grall@arm.com>
The variable enabled_cpus is used to know the number of CPU enabled in
the MADT.
Currently this variable is used to check the validity of the boot CPU.
It will be considered invalid when "enabled_cpus > 1".
However, this condition also means that multiple CPUs are present on the
system. So secondary will never be brought up.
The correct way to check the validity of the boot CPU is to use the
variable bootcpu_valid.
Signed-off-by: Julien Grall <julien.grall@arm.com>
---
xen/arch/arm/acpi/boot.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/arch/arm/acpi/boot.c b/xen/arch/arm/acpi/boot.c
index 2a71660..fd29bdc 100644
--- a/xen/arch/arm/acpi/boot.c
+++ b/xen/arch/arm/acpi/boot.c
@@ -149,7 +149,7 @@ void __init acpi_smp_init_cpus(void)
return;
}
- if ( enabled_cpus > 1 )
+ if ( !bootcpu_valid )
{
printk("MADT missing boot CPU MPIDR, not enabling secondaries\n");
return;
--
1.9.1
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-04-07 10:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-07 10:59 [for-4.7 0/5] xen/arm: acpi: Bunch of fixes to use ACPI with SMP and PL011 Julien Grall
2016-04-07 10:59 ` [for-4.7 1/5] drivers/pl011: ACPI: The interrupt should always be high level triggered Julien Grall
2016-04-07 12:30 ` Shannon Zhao
2016-04-07 13:41 ` Julien Grall
2016-04-07 13:57 ` Shannon Zhao
2016-04-07 13:59 ` Julien Grall
2016-04-07 10:59 ` [for-4.7 2/5] xen/arm: acpi: The boot CPU does not always match the first entry in the MADT Julien Grall
2016-04-07 12:49 ` Shannon Zhao
2016-04-10 20:16 ` Stefano Stabellini
2016-04-07 10:59 ` Julien Grall [this message]
2016-04-07 12:20 ` [for-4.7 3/5] xen/arm: acpi: Fix SMP support when booting with ACPI Shannon Zhao
2016-04-10 20:18 ` Stefano Stabellini
2016-04-07 10:59 ` [for-4.7 4/5] xen/arm: acpi: Remove uncessary check in acpi_map_gic_cpu_interface Julien Grall
2016-04-07 12:23 ` Shannon Zhao
2016-04-10 20:19 ` Stefano Stabellini
2016-04-07 10:59 ` [for-4.7 5/5] xen/arm: acpi: Print more error messages " Julien Grall
2016-04-07 12:22 ` Shannon Zhao
2016-04-10 20:21 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1460026796-10899-4-git-send-email-julien.grall@arm.com \
--to=julien.grall@arm.com \
--cc=shannon.zhao@linaro.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).