From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH v4 01/14] x86/boot: enumerate documentation for the x86 hardware_subarch Date: Thu, 07 Apr 2016 14:25:38 +0300 Message-ID: <1460028338.6620.19.camel@linux.intel.com> References: <1459987594-5434-1-git-send-email-mcgrof@kernel.org> <1459987594-5434-2-git-send-email-mcgrof@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1459987594-5434-2-git-send-email-mcgrof@kernel.org> Sender: linux-kernel-owner@vger.kernel.org To: "Luis R. Rodriguez" , bp@alien8.de, hpa@zytor.com, tglx@linutronix.de, mingo@redhat.com, rusty@rustcorp.com.au Cc: x86@kernel.org, linux-kernel@vger.kernel.org, luto@amacapital.net, boris.ostrovsky@oracle.com, david.vrabel@citrix.com, konrad.wilk@oracle.com, xen-devel@lists.xensource.com, lguest@lists.ozlabs.org, jlee@suse.com, glin@suse.com, matt@codeblueprint.co.uk, andrew.cooper3@citrix.com List-Id: xen-devel@lists.xenproject.org On Wed, 2016-04-06 at 17:06 -0700, Luis R. Rodriguez wrote: > Although hardware_subarch has been in place since the x86 boot > protocol 2.07 it hasn't been used much. Enumerate current possible > values to avoid misuses and help with semantics later at boot > time should this be used further. >=20 > These enums should only ever be used by architecture x86 code, > and all that code should be well contained and compartamentalized, > clarify that as well. Nitpick: > + * @X86_SUBARCH_PC: Should be used if the hardware is enumerable > using standard > + * PC mechanisms (PCI, ACPI) and doesn't need a special boot > flow. > + * @X86_SUBARCH_LGUEST: Used for x86 hypervisor demo, lguest > + * @X86_SUBARCH_XEN: Used for Xen guest types which follow the PV > boot path, > + *=C2=A0 which start at asm startup_xen() entry point and later > jump to the C > + *=C2=A0 xen_start_kernel() entry point. > + * @X86_SUBARCH_INTEL_MID: Used for Intel MID (Mobile Internet > Device) platform > + * systems which do not have the PCI legacy interfaces. > + * @X86_SUBARCH_CE4100: Used for Intel CE media processor (CE4100) > SOC for I think 'SoC' (without quotes) will be better. > + *=C2=A0 for settop boxes and media devices, the use of a subarch > for CE4100 > + *=C2=A0 is more of a hack... --=20 Andy Shevchenko Intel Finland Oy