From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH v2 01/10] libxl_pci: improve return codes
 for more xl commands
Date: Fri, 8 Apr 2016 10:00:49 +0200
Message-ID: <1460102449.13871.11.camel@citrix.com>
References: <1459943163-18697-1-git-send-email-paulinaszubarczyk@gmail.com>
 <1459943163-18697-2-git-send-email-paulinaszubarczyk@gmail.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2311037020240939067=="
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
 by lists.xenproject.org with esmtp (Exim 4.84_2)
 (envelope-from <prvs=899e9c19a=dario.faggioli@citrix.com>)
 id 1aoRLo-0002L5-48
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2016 08:01:08 +0000
In-Reply-To: <1459943163-18697-2-git-send-email-paulinaszubarczyk@gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xen.org
Sender: "Xen-devel" <xen-devel-bounces@lists.xen.org>
To: Paulina Szubarczyk <paulinaszubarczyk@gmail.com>, xen-devel@lists.xenproject.org, roger.pau@citrix.com, George.Dunlap@eu.citrix.com
Cc: ian.jackson@eu.citrix.com, wei.liu2@citrix.com, ian.campbell@citrix.com
List-Id: xen-devel@lists.xenproject.org

--===============2311037020240939067==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-VjRGcloFC03Biy/UG/Gj"

--=-VjRGcloFC03Biy/UG/Gj
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, 2016-04-06 at 13:45 +0200, Paulina Szubarczyk wrote:
> Return error code instead of always 0. Remove assigned-only ret
> variable.
>=20
> Signed-off-by: Paulina Szubarczyk <paulinaszubarczyk@gmail.com>
>=20
> ---
>
I think a better subject would be:

=C2=A0"libxl: improve return codes for some pci related functions"

or something like that.

And in the changelog, I'd say something like:

"libxl__device_from_pcidev() can be void,=C2=A0
=C2=A0while=C2=A0libxl__create_pci_backend() should propagate the success/e=
rror,=C2=A0
=C2=A0rather than always returning 0."

or something like that. :-)

> diff --git a/tools/libxl/libxl_pci.c b/tools/libxl/libxl_pci.c
> index dc10cb7..9c9cd04 100644
> --- a/tools/libxl/libxl_pci.c
> +++ b/tools/libxl/libxl_pci.c
>
The code looks ok to me.

Regards,
Dario
--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


--=-VjRGcloFC03Biy/UG/Gj
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEABECAAYFAlcHZTEACgkQk4XaBE3IOsSa9ACgmvoHPj921R4lpxmBhIAHfO7I
2EUAni59Bnxlv641z80h9l72VFpM952h
=Yv52
-----END PGP SIGNATURE-----

--=-VjRGcloFC03Biy/UG/Gj--


--===============2311037020240939067==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs
IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y
Zy94ZW4tZGV2ZWwK

--===============2311037020240939067==--