From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH v2 05/10] xl_cmdimpl: improve return codes
 for memset commands
Date: Fri, 8 Apr 2016 10:26:39 +0200
Message-ID: <1460103999.13871.31.camel@citrix.com>
References: <1459943163-18697-1-git-send-email-paulinaszubarczyk@gmail.com>
 <1459943163-18697-6-git-send-email-paulinaszubarczyk@gmail.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1093220177426769679=="
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta6.messagelabs.com ([85.158.143.247])
 by lists.xenproject.org with esmtp (Exim 4.84_2)
 (envelope-from <prvs=899e9c19a=dario.faggioli@citrix.com>)
 id 1aoRkf-00047P-JG
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2016 08:26:49 +0000
In-Reply-To: <1459943163-18697-6-git-send-email-paulinaszubarczyk@gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xen.org
Sender: "Xen-devel" <xen-devel-bounces@lists.xen.org>
To: Paulina Szubarczyk <paulinaszubarczyk@gmail.com>, xen-devel@lists.xenproject.org, roger.pau@citrix.com, George.Dunlap@eu.citrix.com
Cc: ian.jackson@eu.citrix.com, wei.liu2@citrix.com, ian.campbell@citrix.com
List-Id: xen-devel@lists.xenproject.org

--===============1093220177426769679==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-gy5MxCg7B9C0Q32esNps"

--=-gy5MxCg7B9C0Q32esNps
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, 2016-04-06 at 13:45 +0200, Paulina Szubarczyk wrote:
> --- a/tools/libxl/xl_cmdimpl.c
> +++ b/tools/libxl/xl_cmdimpl.c
> @@ -3391,15 +3391,15 @@ static int set_memory_max(uint32_t domid,
> const char *mem)
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0memorykb =3D parse_mem_size_kb(mem);
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0if (memorykb =3D=3D -1) {
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0fprintf(stderr, "in=
valid memory size: %s\n", mem);
> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0exit(3);
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0return 1;
>
Mmmm.. I see no reason why this can't remain exit(). In fact, it should
be turned int exit(EXIT_FAILURE), and there's Harmandeep's series --
just resubmitted by me tonight-- outstanding that does that [1].

In any case, this patch is probably not necessary any longer, not
because Harmandeep pending series, but because George take care of what
I think you're trying to do in here in
commit=C2=A00614c454209ac67016e2296577abfee9e9dcb012 already.

Regards,
Dario

[1]=C2=A0http://lists.xenproject.org/archives/html/xen-devel/2016-04/msg010=
99.html
--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


--=-gy5MxCg7B9C0Q32esNps
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEABECAAYFAlcHaz8ACgkQk4XaBE3IOsTt3ACgj1tjJYmWHtNjRg1VfrHWyEqV
WuEAn2tEmPUS0XsD9EdX0bvnRxDsjQnl
=pDWl
-----END PGP SIGNATURE-----

--=-gy5MxCg7B9C0Q32esNps--


--===============1093220177426769679==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs
IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y
Zy94ZW4tZGV2ZWwK

--===============1093220177426769679==--