From: "Luis R. Rodriguez" <mcgrof@kernel.org>
To: bp@alien8.de, hpa@zytor.com, tglx@linutronix.de,
mingo@redhat.com, rusty@rustcorp.com.au
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
luto@amacapital.net, boris.ostrovsky@oracle.com,
david.vrabel@citrix.com, konrad.wilk@oracle.com,
xen-devel@lists.xensource.com, lguest@lists.ozlabs.org,
andriy.shevchenko@linux.intel.com, jlee@suse.com, glin@suse.com,
matt@codeblueprint.co.uk, andrew.cooper3@citrix.com,
rjw@rjwysocki.net, lenb@kernel.org, robert.moore@intel.com,
lv.zheng@intel.com, toshi.kani@hp.com,
linux-acpi@vger.kernel.org, kozerkov@parallels.com,
josh@joshtriplett.org, joro@8bytes.org, tiwai@suse.de,
sathyanarayanan.kuppuswamy@linux.intel.com, alan@linux.intel.com,
rui.zhang@intel.com, mbizon@freebox.fr, bigeasy@linutronix.de,
ffainelli@freebox.fr, george.dunlap@citrix.com,
julien.grall@linaro.org, "Luis R. Rodriguez" <mcgrof@kernel.org>
Subject: [PATCH v2] x86/init: disable pnpbios and rtc for X86_SUBARCH_CE4100
Date: Tue, 12 Apr 2016 15:44:58 -0700 [thread overview]
Message-ID: <1460501098-28132-1-git-send-email-mcgrof@kernel.org> (raw)
In-Reply-To: <20160412223012.GO1990@wotan.suse.de>
As per hpa CE4100 platforms can also disable pnpbios [0].
Then Sebastian also recently noted that CE4100 also disables
RTC probe, to do that Sebastian had long ago added the RTC
of_have_populated_dt() check, he noted that it was meant to
skip the RTC probe on all OF platforms but as of now, CE4100
was the only x86 DT using this.
We can just fold this requirement into the platform quirk
then. This now means that all of these match platform quirks
for pnpbios and RTC preferences:
* X86_SUBARCH_XEN
* X86_SUBARCH_LGUEST
* X86_SUBARCH_INTEL_MID
* X86_SUBARCH_CE4100
[0] http://lkml.kernel.org/r/5702B5C2.7070101@zytor.com
[1] http://lkml.kernel.org/r/570B52EA.60300@linutronix.de
Suggested-by: H. Peter Anvin <hpa@zytor.com>
Suggested-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
---
This series on the other paravirt_enabled() series, I'll be testing
one more change to update one patch to reduce more space on __init,
the 0-day testing should be done by tomorrow and then I can adjust
the size computation on impact size.
arch/x86/kernel/platform-quirks.c | 1 +
arch/x86/kernel/rtc.c | 3 ---
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/arch/x86/kernel/platform-quirks.c b/arch/x86/kernel/platform-quirks.c
index 853919484340..b2f8a33b36ff 100644
--- a/arch/x86/kernel/platform-quirks.c
+++ b/arch/x86/kernel/platform-quirks.c
@@ -17,6 +17,7 @@ void __init x86_early_init_platform_quirks(void)
case X86_SUBARCH_XEN:
case X86_SUBARCH_LGUEST:
case X86_SUBARCH_INTEL_MID:
+ case X86_SUBARCH_CE4100:
x86_platform.legacy.devices.pnpbios = 0;
x86_platform.legacy.rtc = 0;
break;
diff --git a/arch/x86/kernel/rtc.c b/arch/x86/kernel/rtc.c
index ff4f4180fefd..eceaa082ec3f 100644
--- a/arch/x86/kernel/rtc.c
+++ b/arch/x86/kernel/rtc.c
@@ -186,9 +186,6 @@ static __init int add_rtc_cmos(void)
}
}
#endif
- if (of_have_populated_dt())
- return 0;
-
if (!x86_platform.legacy.rtc)
return -ENODEV;
--
2.7.2
next prev parent reply other threads:[~2016-04-12 22:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-09 0:22 [PATCH v1 0/2] x86/init: extend quirk use Luis R. Rodriguez
2016-04-09 0:22 ` [PATCH v1 1/2] x86/init: disable pnpbios for X86_SUBARCH_INTEL_MID Luis R. Rodriguez
2016-04-13 23:33 ` Luis R. Rodriguez
2016-04-09 0:22 ` [PATCH v1 2/2] x86/init: disable pnpbios for X86_SUBARCH_CE4100 Luis R. Rodriguez
2016-04-11 7:31 ` [PATCH v1 0/2] x86/init: extend quirk use Sebastian Andrzej Siewior
2016-04-12 22:30 ` Luis R. Rodriguez
2016-04-12 22:44 ` Luis R. Rodriguez [this message]
2016-04-13 23:36 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1460501098-28132-1-git-send-email-mcgrof@kernel.org \
--to=mcgrof@kernel.org \
--cc=alan@linux.intel.com \
--cc=andrew.cooper3@citrix.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bigeasy@linutronix.de \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=david.vrabel@citrix.com \
--cc=ffainelli@freebox.fr \
--cc=george.dunlap@citrix.com \
--cc=glin@suse.com \
--cc=hpa@zytor.com \
--cc=jlee@suse.com \
--cc=joro@8bytes.org \
--cc=josh@joshtriplett.org \
--cc=julien.grall@linaro.org \
--cc=konrad.wilk@oracle.com \
--cc=kozerkov@parallels.com \
--cc=lenb@kernel.org \
--cc=lguest@lists.ozlabs.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=lv.zheng@intel.com \
--cc=matt@codeblueprint.co.uk \
--cc=mbizon@freebox.fr \
--cc=mingo@redhat.com \
--cc=rjw@rjwysocki.net \
--cc=robert.moore@intel.com \
--cc=rui.zhang@intel.com \
--cc=rusty@rustcorp.com.au \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=tiwai@suse.de \
--cc=toshi.kani@hp.com \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).