From: Peng Fan <van.freenix@gmail.com>
To: xen-devel@lists.xen.org
Cc: van.freenix@gmail.com, Julien Grall <julien.grall@arm.com>,
Stefano Stabellini <sstabellini@kernel.org>
Subject: [PATCH 1/2] xen/arm64: correct comments
Date: Wed, 20 Apr 2016 21:54:23 +0800 [thread overview]
Message-ID: <1461160464-2194-1-git-send-email-van.freenix@gmail.com> (raw)
The 'Base address for 4K mapping' is '(x19 >> THIRD_SHIFT) << THIRD_SHIFT'.
Also we are building 4K page mapping, not section mapping.
Signed-off-by: Peng Fan <van.freenix@gmail.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>
Cc: Julien Grall <julien.grall@arm.com>
---
xen/arch/arm/arm64/head.S | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S
index 946e2c9..05e3db0 100644
--- a/xen/arch/arm/arm64/head.S
+++ b/xen/arch/arm/arm64/head.S
@@ -471,10 +471,10 @@ skip_bss:
ldr x4, =boot_third
add x4, x4, x20 /* x4 := paddr (boot_third) */
- lsr x2, x19, #THIRD_SHIFT /* Base address for 4K mapping */
- lsl x2, x2, #THIRD_SHIFT
- mov x3, #PT_MEM_L3 /* x2 := Section map */
- orr x2, x2, x3
+ lsr x2, x19, #THIRD_SHIFT
+ lsl x2, x2, #THIRD_SHIFT /* Base address for 4K mapping */
+ mov x3, #PT_MEM_L3
+ orr x2, x2, x3 /* x2 := Page map */
/* ... map of vaddr(start) in boot_third */
mov x1, xzr
--
2.6.2
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next reply other threads:[~2016-04-20 13:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-20 13:54 Peng Fan [this message]
2016-04-20 13:54 ` [PATCH 2/2] xen/arm64: use shift operator Peng Fan
2016-04-20 14:44 ` Julien Grall
2016-04-21 1:06 ` Peng Fan
2016-04-22 16:08 ` Julien Grall
2016-04-23 13:28 ` Peng Fan
2016-04-22 16:24 ` [PATCH 1/2] xen/arm64: correct comments Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1461160464-2194-1-git-send-email-van.freenix@gmail.com \
--to=van.freenix@gmail.com \
--cc=julien.grall@arm.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).