[PATCH] add info to p2m_pod_dump_data

[PATCH] add info to p2m_pod_dump_data

[zhangcy]

just for debug.
'xl debug-key q' do not dump d->tot_pages,
so it hard to understand p2m_pod_set_mem_target.

Signed-off-by: zhangcy <zhangcy@cn.fujitsu.com>
---
 xen/arch/x86/mm/p2m-pod.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/xen/arch/x86/mm/p2m-pod.c b/xen/arch/x86/mm/p2m-pod.c
index 35835d1..a931f2c 100644
--- a/xen/arch/x86/mm/p2m-pod.c
+++ b/xen/arch/x86/mm/p2m-pod.c
@@ -660,8 +660,8 @@ void p2m_pod_dump_data(struct domain *d)
 {
     struct p2m_domain *p2m = p2m_get_hostp2m(d);
 
-    printk("    PoD entries=%ld cachesize=%ld\n",
-           p2m->pod.entry_count, p2m->pod.count);
+    printk("    Total pages=%d PoD entries=%ld cachesize=%ld\n",
+           d->tot_pages, p2m->pod.entry_count, p2m->pod.count);
 }
 
 
-- 
1.7.12.4




_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [PATCH] add info to p2m_pod_dump_data

[George Dunlap]

On 26/04/16 05:11, zhangcy wrote:
> just for debug.
> 'xl debug-key q' do not dump d->tot_pages,
> so it hard to understand p2m_pod_set_mem_target.

debug-key 'q' calls dump_domains, which prints d->tot_pages under the
label "nr_pages".

I admit this isn't very clear -- what about s/nr_pages/tot_pages/ these
instead?

 -George


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [PATCH] add info to p2m_pod_dump_data

[George Dunlap]

On 26/04/16 05:11, zhangcy wrote:
> just for debug.
> 'xl debug-key q' do not dump d->tot_pages,
> so it hard to understand p2m_pod_set_mem_target.
> 
> Signed-off-by: zhangcy <zhangcy@cn.fujitsu.com>

Also, the SoB is a legal statement, so in future patches you should
change "zhangcy" to something which resembles your actual name.

 -George


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel