From: Roger Pau Monne <roger.pau@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Wei Liu <wei.liu2@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
Roger Pau Monne <roger.pau@citrix.com>
Subject: [PATCH v3 for-4.7 16/16] tools/pygrub: fix usage of LDFLAGS
Date: Wed, 27 Apr 2016 13:11:54 +0200 [thread overview]
Message-ID: <1461755514-23754-17-git-send-email-roger.pau@citrix.com> (raw)
In-Reply-To: <1461755514-23754-1-git-send-email-roger.pau@citrix.com>
LDFLAGS cannot be appended to CFLAGS, instead pass them down as env
variables.
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>
---
tools/pygrub/Makefile | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/tools/pygrub/Makefile b/tools/pygrub/Makefile
index fe8e03b..a318490 100644
--- a/tools/pygrub/Makefile
+++ b/tools/pygrub/Makefile
@@ -2,7 +2,8 @@
XEN_ROOT = $(CURDIR)/../..
include $(XEN_ROOT)/tools/Rules.mk
-PY_CFLAGS = $(CFLAGS) $(PY_NOOPT_CFLAGS) $(APPEND_LDFLAGS)
+PY_CFLAGS = $(CFLAGS) $(PY_NOOPT_CFLAGS)
+PY_LDFLAGS = $(LDFLAGS) $(APPEND_LDFLAGS)
.PHONY: all
all: build
@@ -12,8 +13,8 @@ build:
.PHONY: install
install: all
- CC="$(CC)" CFLAGS="$(PY_CFLAGS)" $(PYTHON) setup.py install \
- $(PYTHON_PREFIX_ARG) --root="$(DESTDIR)" \
+ CC="$(CC)" CFLAGS="$(PY_CFLAGS)" LDFLAGS="$(PY_LDFLAGS)" $(PYTHON) \
+ setup.py install $(PYTHON_PREFIX_ARG) --root="$(DESTDIR)" \
--install-scripts=$(LIBEXEC_BIN) --force
set -e; if [ $(bindir) != $(LIBEXEC_BIN) -a \
"`readlink -f $(DESTDIR)/$(bindir)`" != \
--
2.6.4 (Apple Git-63)
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-04-27 11:12 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-27 11:11 [PATCH v3 for-4.7 00/16] Fixes for compiling with clang Roger Pau Monne
2016-04-27 11:11 ` [PATCH v3 for-4.7 01/16] build: make HOSTCC conditional on the value of clang Roger Pau Monne
2016-04-27 11:11 ` [PATCH v3 for-4.7 02/16] build: set HOSTCXX based on clang value for Kconfig xconfig target Roger Pau Monne
2016-04-27 11:11 ` [PATCH v3 for-4.7 03/16] build: pass HOST{CC/CXX} value down to Kconfig Roger Pau Monne
2016-04-27 11:11 ` [PATCH v3 for-4.7 04/16] build: remove Kconfig forced gcc selection Roger Pau Monne
2016-04-27 11:11 ` [PATCH v3 for-4.7 05/16] tools/headers: prevent adding two __align8__ to uint64_t in ARM headers Roger Pau Monne
2016-04-27 11:11 ` [PATCH v3 for-4.7 06/16] xen/tools: fix substitution of __align8__ uint64_t inside of headers Roger Pau Monne
2016-04-27 11:11 ` [PATCH v3 for-4.7 07/16] libxc: fix usage of uninitialized variable Roger Pau Monne
2016-04-27 11:22 ` Wei Liu
2016-04-27 13:18 ` Wei Liu
2016-04-28 17:43 ` Ian Jackson
2016-05-09 17:10 ` Ian Jackson
2016-04-27 11:11 ` [PATCH v3 for-4.7 08/16] libxl: fix shutdown_reason type in list_domains Roger Pau Monne
2016-04-27 11:11 ` [PATCH v3 for-4.7 09/16] xl: fix usage of libxl_get_scheduler Roger Pau Monne
2016-04-27 11:24 ` Wei Liu
2016-04-27 11:11 ` [PATCH v3 for-4.7 10/16] libxl: add the printf-like attributes to a couple of functions Roger Pau Monne
2016-04-27 11:25 ` Wei Liu
2016-04-27 11:11 ` [PATCH v3 for-4.7 11/16] libxl: convert libxl__device_model_xs_path to a macro Roger Pau Monne
2016-04-27 11:26 ` Wei Liu
2016-04-27 11:11 ` [PATCH v3 for-4.7 12/16] libxl: add explicit casts from yajl_gen_status to yajl_status Roger Pau Monne
2016-04-27 11:11 ` [PATCH v3 for-4.7 13/16] libxl: fix passing the type argument to xc_psr_* Roger Pau Monne
2016-04-27 11:11 ` [PATCH v3 for-4.7 14/16] oxenstored: fix error when shifting negative value Roger Pau Monne
2016-04-27 11:26 ` Wei Liu
2016-04-27 11:11 ` [PATCH v3 for-4.7 15/16] tools/python: corrently use LDFLAGS and CFLAGS Roger Pau Monne
2016-04-27 11:11 ` Roger Pau Monne [this message]
2016-04-27 11:27 ` [PATCH v3 for-4.7 16/16] tools/pygrub: fix usage of LDFLAGS Wei Liu
2016-04-27 13:23 ` [PATCH v3 for-4.7 00/16] Fixes for compiling with clang Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1461755514-23754-17-git-send-email-roger.pau@citrix.com \
--to=roger.pau@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).